Open
Conversation
| // GitHub Issue 925: Not providing a MVTC value in an assay result throws error | ||
| // convert blank to empty array, not null | ||
| values[i] = column.converter.convert(column.clazz, fld); | ||
| } |
Contributor
There was a problem hiding this comment.
Hmm, another example of why I'd love if DataLoader stopped doing conversions altogether.
labkey-matthewb
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Updating a sample details page shows an update to the MVTC field even when it didn't change
https://github.com/LabKey/internal-issues/issues/913
Using MVTC field in Ancestry Naming Pattern is always blank
https://github.com/LabKey/internal-issues/issues/914
Renamed text choice with a ; displays wrong
https://github.com/LabKey/internal-issues/issues/923
Updating Single Text choice values errors
https://github.com/LabKey/internal-issues/issues/924
Not providing a MVTC value in an assay result throws error
https://github.com/LabKey/internal-issues/issues/925
GitHub Issue 935 Changing from MVTC to TC wraps all values in curly braces
Related Pull Requests
Changes