Fix StorageNameGenerator$TestCase on SQL Server#7481
Merged
labkey-adam merged 1 commit intorelease26.3-SNAPSHOTfrom Mar 9, 2026
Merged
Fix StorageNameGenerator$TestCase on SQL Server#7481labkey-adam merged 1 commit intorelease26.3-SNAPSHOTfrom
labkey-adam merged 1 commit intorelease26.3-SNAPSHOTfrom
Conversation
labkey-matthewb
approved these changes
Mar 9, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Now that storage names always use the PostgreSQL rules, test must check their lengths using the PostgreSQL dialect.
No manual testing or automated test updates needed since this was caught by an existing test (that never ran on the original feature branch, for some reason).
Related Pull Requests