Add support for sample creation actions in workflow jobs#1951
Open
labkey-susanh wants to merge 31 commits intodevelopfrom
Open
Add support for sample creation actions in workflow jobs#1951labkey-susanh wants to merge 31 commits intodevelopfrom
labkey-susanh wants to merge 31 commits intodevelopfrom
Conversation
…to `workflow` schema
labkey-alan
approved these changes
Mar 11, 2026
| if ( | ||
| lcSchemaName === SCHEMAS.WORKFLOW.SCHEMA && | ||
| lcQueryName === SCHEMAS.WORKFLOW.JOB_INPUT_SAMPLES.queryName.toLowerCase() | ||
| ) |
Contributor
There was a problem hiding this comment.
FYI in my open PR I have added an arg to SchemaQuery.isEqual to allow you to easily compare two SchemaQuery objects without comparing their view names, which I think would be useful in this method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Minor updates in support of adding sample creation actions to workflow jobs, which is reusing a good amount of the UI we have for creation from grid buttons.
Related Pull Requests
Changes
isAllSamplesSchemato account for move ofJobInputSamplestoworkflowschemaDisableableButton