Handle "StartTestTime" attribute on each Test entry#3450
Merged
williamjallen merged 1 commit intoKitware:masterfrom Feb 14, 2026
Merged
Handle "StartTestTime" attribute on each Test entry#3450williamjallen merged 1 commit intoKitware:masterfrom
williamjallen merged 1 commit intoKitware:masterfrom
Conversation
williamjallen
requested changes
Feb 13, 2026
Collaborator
williamjallen
left a comment
williamjallen
left a comment
There was a problem hiding this comment.
Let's also add a test case to tests/Feature/Submission/Tests/TestXMLTest.php to verify that submissions with and without this field still work.
josephsnyder
force-pushed
the
add_test_TestStartTime_handling
branch
2 times, most recently
from
598a0ed to
a614895
Compare
williamjallen
requested changes
Feb 13, 2026
Collaborator
williamjallen
left a comment
williamjallen
left a comment
There was a problem hiding this comment.
While you're at it, can you go ahead and add this to the GraphQL API?
josephsnyder
force-pushed
the
add_test_TestStartTime_handling
branch
from
a614895 to
ab3f991
Compare
williamjallen
requested changes
Feb 13, 2026
Collaborator
williamjallen
left a comment
williamjallen
left a comment
There was a problem hiding this comment.
The startTime field should also be added to testBasicFieldAccess() in tests/Feature/GraphQL/TestTypeTest.php.
josephsnyder
force-pushed
the
add_test_TestStartTime_handling
branch
from
ab3f991 to
b230a05
Compare
CTest includes the start time of each individual test as of the merge in https://gitlab.kitware.com/cmake/cmake/-/merge_requests/11684 Add the validation and the parsing of the field for the build2test table and the Test model.
josephsnyder
force-pushed
the
add_test_TestStartTime_handling
branch
from
b230a05 to
0353e02
Compare
williamjallen
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CTest includes the start time of each individual test as of the merge in https://gitlab.kitware.com/cmake/cmake/-/merge_requests/11684
Add the validation and the parsing of the field for the build2test table and the Test model.