Open
Conversation
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
n7studios
requested review from
a team,
ciccio-kit and
noelherrick
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue introduced in #723, which allowed creators to choose where to display forms in Pages, Posts, and Custom Post Types (e.g., after the 3rd paragraph).
Previously, the implementation injected the entire
$form_node->documentElementinto the content using PHP'sDOMDocument, which inadvertently included<html>and<head>tags.This update instead extracts only the form’s actual node(s) (typically just a
<script>or form fragment) and inserts them at the specified location in the Page/Post/CPT, avoiding any unintended root-level HTML tags.Testing
Updated tests to confirm no additional
<html>,<head>or<body>tags are included in the DOM.Checklist