Skip to content

Fix multithreaded symlink crash #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Matistjati wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix multithreaded symlink crash #393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions problemtools/verifyproblem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1730,10 +1730,12 @@ def _gather_testcases(self, item: TestCase | TestCaseGroup) -> list[TestCase]:
if not item.matches_filter(self._context.data_filter):
return []
if isinstance(item, TestCase):
if item.reuse_result_from:
return self._gather_testcases(item.reuse_result_from)
else:
return [item]
# If testcase is symlink, recursively follow the symlinks until we get a real testcase, ignoring
# whether the name of testcases pointed to matches the filter
while item.reuse_result_from:
item = item.reuse_result_from

return [item]
elif item not in self._done_groups:
ret = []
for child in item.get_testcases() + item.get_subgroups():
Expand Down