Conversation
|
@cjdoris any interest on reviewing? |
|
Hiya, sorry to not pick this up for a while. I actually read through this a while ago and had some reservations but forgot to reply! It certainly seems reasonable to want to add more information to the first line, so it shows up nicely in the vscode inline viewer, but doing this in all cases where we print multiline makes the output quite noisy. For example here's how versus if I add a bit of type information: we end up with the word "Array" or "Matrix" 3 times, and "Julia" 2 times and overall it's quite a lot to take in. The old behaviour just falls back to how Julia displays the thing, plus the words "Python" and "Julia" which minimally show how the value is wrapped. So maybe we could do this but only if we can tell it's being called to be displayed in the VSCode inline viewer. I don't know how we could reasonably do this. The only arg to io.dict = Base.ImmutableDict{Symbol, Any}(:displaysize => (30, 64), :color => false, :limit => true) |
|
Type information might not be important to users. I' m just proposing to add size and dtype info. Is the example generated with my proposed code? |
|
Yep the example was using your branch, but I made some modifications playing around with it to see what worked. I think what actually might be a nice simple generic thing would be to have it show like This would only need two very small changes:
Thoughts? |
fix #361