Skip to content

Detector changed hook#905

Draft
baltzell wants to merge 53 commits intodevelopmentfrom
detector-changed-hook
Draft

Detector changed hook#905
baltzell wants to merge 53 commits intodevelopmentfrom
detector-changed-hook

Conversation

@baltzell
Copy link
Collaborator

@baltzell baltzell commented Oct 23, 2025

No description provided.

@baltzell baltzell added this to the Real Run Number Simulations milestone Oct 23, 2025
@baltzell baltzell added the gemc label Oct 23, 2025
@baltzell baltzell force-pushed the detector-changed-hook branch 3 times, most recently from 509c95a to 8492640 Compare November 13, 2025 23:25
@baltzell baltzell mentioned this pull request Dec 3, 2025
Closed
@baltzell baltzell force-pushed the detector-changed-hook branch 3 times, most recently from cbbe1a5 to 5f34968 Compare December 12, 2025 20:30
@baltzell baltzell force-pushed the detector-changed-hook branch 4 times, most recently from 97bf69f to d290802 Compare December 23, 2025 15:39
@baltzell baltzell mentioned this pull request Jan 9, 2026
Closed
@baltzell baltzell force-pushed the detector-changed-hook branch from e84fd3e to 124232c Compare January 12, 2026 15:01
@baltzell
Copy link
Collaborator Author

baltzell commented Jan 12, 2026

If not already done, #441's changes should be included here.

@baltzell baltzell force-pushed the detector-changed-hook branch from 1563cd9 to 136de6f Compare January 16, 2026 01:27
@baltzell baltzell force-pushed the detector-changed-hook branch from bb5bb4e to 74285f0 Compare January 30, 2026 03:30
baltzell and others added 29 commits February 3, 2026 10:19
@baltzell
remove unused/unnecessary script
a1a56a9
@baltzell
disable workflow for now
97c5f99
@baltzell
add neutron test
1362a51
@baltzell
remove leftovers
75e47c6
@baltzell
abort on error
1e6d027
@baltzell
fix rebase mistake
75eecd0
@baltzell
add missing overrides
f50992c
@baltzell
add missing overrides
39488ed
@baltzell
add missing overrides
ce492fc
@raffaelladevita @baltzell
accounting for tstart, tflight and tprop in MC tracks reconstruction
af33838
@raffaelladevita @baltzell
removed check on run number when setting the DC hit uncertainty
a2c64d9
@raffaelladevita @baltzell
removed hardcoded change to default variation in BAND engine
d05dbb4
@raffaelladevita @baltzell
apply TDC jitter correction only if TI timestamp is >0, excluding MC …
6c9769f 
…events
@raffaelladevita @baltzell
moved RF offsets to time written to RUN::rf bank
67a9b09
@raffaelladevita @baltzell
fixed bug in REC::Event.RFTime introduced with last commit
c44106e
@raffaelladevita @baltzell
restored TDC jitter correction for timestamp=0
f8174e1
@raffaelladevita @baltzell
switch to load geometry for real run number
8b70089
@baltzell
fix env
8c84922
@baltzell
add missing override
b2308b3
@baltzell
remove unused imports
30c0952
@baltzell
set PATH
b567013
@baltzell
add missing overrides
d37c455
@baltzell
add missing overrides
a420307
@raffaelladevita @baltzell
propagate detectorChanged and method renaming to new UberEngine
a43c36f
@raffaelladevita @baltzell
changed EC to load the geometry with the real run number
8f78e52
@baltzell
fix merge mistake
0d1903f
@raffaelladevita @baltzell
new EB test files
9a7483d
@raffaelladevita @baltzell
undoing RF offset changes
3758222
@baltzell
add missing overrides
3ecf271
@baltzell baltzell force-pushed the detector-changed-hook branch from 74285f0 to 3ecf271 Compare February 3, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raffaelladevita raffaelladevita Awaiting requested review from raffaelladevita raffaelladevita will be requested when the pull request is marked ready for review raffaelladevita is a code owner

@c-dilks c-dilks Awaiting requested review from c-dilks c-dilks will be requested when the pull request is marked ready for review c-dilks is a code owner

@zieglerv zieglerv Awaiting requested review from zieglerv zieglerv will be requested when the pull request is marked ready for review zieglerv is a code owner

@tongtongcao tongtongcao Awaiting requested review from tongtongcao tongtongcao will be requested when the pull request is marked ready for review tongtongcao is a code owner

@mathieuouillon mathieuouillon Awaiting requested review from mathieuouillon mathieuouillon will be requested when the pull request is marked ready for review mathieuouillon is a code owner

@Hattawy Hattawy Awaiting requested review from Hattawy Hattawy will be requested when the pull request is marked ready for review Hattawy is a code owner

@drewkenjo drewkenjo Awaiting requested review from drewkenjo drewkenjo will be requested when the pull request is marked ready for review drewkenjo is a code owner

@mcontalb mcontalb Awaiting requested review from mcontalb mcontalb will be requested when the pull request is marked ready for review mcontalb is a code owner

@silvianic silvianic Awaiting requested review from silvianic silvianic will be requested when the pull request is marked ready for review silvianic is a code owner

@N-Plx N-Plx Awaiting requested review from N-Plx N-Plx will be requested when the pull request is marked ready for review N-Plx is a code owner

@rafopar rafopar Awaiting requested review from rafopar rafopar will be requested when the pull request is marked ready for review rafopar is a code owner

@forcar forcar Awaiting requested review from forcar forcar will be requested when the pull request is marked ready for review forcar is a code owner

@hauenst hauenst Awaiting requested review from hauenst hauenst will be requested when the pull request is marked ready for review hauenst is a code owner

@ajhobart ajhobart Awaiting requested review from ajhobart ajhobart will be requested when the pull request is marked ready for review ajhobart is a code owner

@mpaolone mpaolone Awaiting requested review from mpaolone mpaolone will be requested when the pull request is marked ready for review mpaolone is a code owner

@efuchey efuchey Awaiting requested review from efuchey efuchey will be requested when the pull request is marked ready for review efuchey is a code owner

@whit2333 whit2333 Awaiting requested review from whit2333 whit2333 will be requested when the pull request is marked ready for review whit2333 is a code owner

@ftouchte ftouchte Awaiting requested review from ftouchte ftouchte will be requested when the pull request is marked ready for review ftouchte is a code owner

@heddle heddle Awaiting requested review from heddle heddle will be requested when the pull request is marked ready for review heddle is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

gemc

Projects

None yet

Milestone

Real Run Number Simulations

Development

Successfully merging this pull request may close these issues.

2 participants

@baltzell @raffaelladevita