Skip to content

Comments

969 bug distributeddata globalfilter#1047

Merged
kuh0005 merged 8 commits intodevfrom
969-bug-distributeddata---globalfilter
Feb 24, 2026
Merged

969 bug distributeddata globalfilter#1047
kuh0005 merged 8 commits intodevfrom
969-bug-distributeddata---globalfilter

Conversation

@kuh0005
Copy link
Collaborator

@kuh0005 kuh0005 commented Feb 23, 2026

This pull request focuses on improving the UI/UX consistency and clarity in the AXOpen.Data.Blazor data exchange components. The main changes involve updating button styles and labels for better user experience, reorganizing UI elements for clarity, and making minor code refactors for maintainability.

UI/UX Improvements:

  • Standardized button styles across the data exchange views, replacing inconsistent or legacy classes (e.g., btn-outline-red to btn-outline-primary or btn-outline-danger) and aligning icon usage for action buttons. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]
  • Updated button labels for clarity and localization, such as changing "Create" to "Create new" and "Create New from PLC" to "Create new from PLC". [1] [2] [3]

UI Structure and Filtering Enhancements:

  • Added semantic data attributes (e.g., data-dataexchange-operations, data-filtering-operations) to key UI sections for better structure and potential testability. [1] [2]
  • Improved filtering UI in DataExchangeQuery.razor by repositioning the filter input, adjusting gap and margin for compactness, and swapping the order of "Clean" and "All" buttons for logical flow.

Sorting and Filtering Logic:

  • Refactored sorting toggle logic: replaced the setSortAscendingAsync method with the more descriptive ToggleSortSettings, and updated the sorting toggle button to display localized "Ascending"/"Descending" text instead of just an icon. [1] [2]
  • Improved sorting and filtering button styles for consistency and clarity. [1] [2] [3]

Code Cleanliness:

  • Minor cleanup of namespace and copyright comments. [1] [2]

Button/Icon Consistency:

  • Updated action buttons in symbol lists to use primary styling for both "Add to Query" and "Add to Sorting" actions, ensuring a unified look.

These changes collectively enhance the usability, maintainability, and visual consistency of the data exchange UI components.

@kuh0005 kuh0005 linked an issue Feb 23, 2026 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request focuses on improving UI/UX consistency and usability in the AXOpen.Data.Blazor data exchange components. The changes primarily involve button style standardization, UI reorganization for better clarity, and refactoring for improved maintainability.

Changes:

  • Standardized button styles across data exchange views by replacing inconsistent CSS classes (e.g., btn-outline-redbtn-outline-primary or btn-outline-danger) and updating icon styling
  • Enhanced UI structure with semantic data attributes for better testability and clearer organization of filtering/operations sections
  • Improved user experience by displaying sort member names directly in buttons, adding localized text for sorting direction, and repositioning filter controls

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/styling/src/wwwroot/css/momentum.css Added new utility classes (size-7, size-8, m-0!) to support UI updates
src/data/src/AXOpen.Data.Blazor/Distributed/DistributedDataView.razor Updated button styles, added data attributes, restructured layout with flex properties, changed count display markup
src/data/src/AXOpen.Data.Blazor/AxoDataExchange/Query/Symbol/QuerySymbolConfigurationView.razor Replaced dropdown component with native select element for operation selection, added AccessStatusClass parameter support
src/data/src/AXOpen.Data.Blazor/AxoDataExchange/Query/Symbol/DynamicInput.razor Added AccessStatusClass parameter and propagated it to input components for consistent styling
src/data/src/AXOpen.Data.Blazor/AxoDataExchange/Query/DataExchangeQuery.razor.cs Enhanced query history loading logic with improved null/empty checks and fallback behavior
src/data/src/AXOpen.Data.Blazor/AxoDataExchange/Query/DataExchangeQuery.razor Reorganized filter UI, swapped button order, updated styles to btn-outline-primary, changed button labels
src/data/src/AXOpen.Data.Blazor/AxoDataExchange/DataExchangeView.razor.cs Renamed method from setSortAscendingAsync to ToggleSortSettings for clarity
src/data/src/AXOpen.Data.Blazor/AxoDataExchange/DataExchangeView.razor Standardized button styles, updated labels ("Create" → "Create new"), changed icon types and sizes, improved sort display with member name

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kuh0005 kuh0005 requested a review from LukasKytka February 24, 2026 05:32
@kuh0005 kuh0005 merged commit 0fa8fa7 into dev Feb 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] DistributedData - GlobalFilter

4 participants