Skip to content

feat: tags#210

Open
kerry-he wants to merge 4 commits intoInftyAI:mainfrom
kerry-he:feature/tags
Open

feat: tags#210
kerry-he wants to merge 4 commits intoInftyAI:mainfrom
kerry-he:feature/tags

Conversation

@kerry-he
Copy link

@kerry-he kerry-he commented Mar 11, 2026

What this PR does / why we need it

Allows tags to be specified as a list of strings, e.g.,

alphatrion.experiment.craft_experiment.CraftExperiment.start(name="experiment", tags=["foo", "bar"])

I will add a separate PR to account for this in the dashboard UI.

Which issue(s) this PR fixes

Fixes #209

Special notes for your reviewer

Does this PR introduce a user-facing change?

Experiments can now be tagged with lists of strings.

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Mar 11, 2026
@InftyAI-Agent InftyAI-Agent requested a review from kerthcet March 11, 2026 06:14
@kerthcet
Copy link
Member

Thanks @kerry-he quoted the offline discussion here for transparency:

maybe let's have a separate tags table, because I don't know how labels will evolve in the future, 
it could be immutable, it could be separated to different kinds of labels, system labels and user labels 
to avoid abuse, since we're developing from scratch, and have a dedicated tags table is not a big deal, 
maybe let's start with a new table, it won't be a mistake decision in the future anyway. 
We'll make lables immutable and tags mutable today.WDYT?

@kerry-he
Copy link
Author

/kind feature

@InftyAI-Agent InftyAI-Agent added feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Mar 12, 2026
@kerry-he
Copy link
Author

Fixed, tags are now a separarate field and uses its own table.

@kerry-he kerry-he changed the title FEAT: tags feat: tags Mar 12, 2026
@kerry-he kerry-he mentioned this pull request Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tags to experiments

4 participants