Open
Conversation
Chamberlain0w0
requested changes
Feb 27, 2026
scripts/common/install_deps.sh
Outdated
| export LD_LIBRARY_PATH="$INFINI_ROOT/lib:$LD_LIBRARY_PATH" | ||
| export NCCL_ROOT="$INFINI_ROOT/nccl" | ||
| export PATH="$NCCL_ROOT/bin:$PATH" | ||
| export LD_LIBRARY_PATH="$NCCL_ROOT/lib:$LD_LIBRARY_PATH" |
Contributor
There was a problem hiding this comment.
这个 NCCL_ROOT 假定的不太合适，用户不会把 nccl 装到 INFINI_ROOT 下面，这几行可以删了
scripts/common/install_deps.sh
Outdated
| } | ||
|
|
||
| # Check NCCL | ||
| check_nccl() { |
Contributor
There was a problem hiding this comment.
这部分我感觉也可以去掉，nccl 应该是基本要求，可以默认用户都装了。另外如果要检查也得先检查头文件，再检查动态库，也有点繁琐
|
|
||
| # Check Megatron-LM | ||
| check_megatron() { | ||
| echo -n " Megatron-LM... " |
Contributor
There was a problem hiding this comment.
这块加个 TODO 或者 FIXME 吧，有可能直接拿源码运行了，而不是通过调用 megatron 的 python 包，等之后这块合进来了得再改下，感觉跟 nccl-tests 一样当作 submodule 引入就行
scripts/common/install_deps.sh
Outdated
| # Check InfiniTrain | ||
| check_infinitrain() { | ||
| echo -n " InfiniTrain... " | ||
| if check_python_package infinitrain; then |
Contributor
There was a problem hiding this comment.
这块也加个 TODO，infinitrain 暂时应该也没 python 包
scripts/common/install_deps.sh
Outdated
| local INFINITRAIN_PATH="${INFINITRAIN_PATH:-$PROJECT_ROOT/submodules/InfiniTrain}" | ||
| if [ -d "$INFINITRAIN_PATH" ]; then | ||
| cd "$INFINITRAIN_PATH" | ||
| if pip install -e .; then |
Contributor
There was a problem hiding this comment.
这块加个 TODO，之后换成实际的 build 方式
scripts/run_tests.sh
Outdated
| ;; | ||
| comm) | ||
| echo "Checking communication dependencies:" | ||
| check_nccl |
scripts/run_tests.sh
Outdated
| all) | ||
| echo "Checking all dependencies:" | ||
| check_cuda | ||
| check_nccl |
| # ======================================== | ||
| # Inference Frameworks | ||
| # ======================================== | ||
| install_inference() { |
Collaborator
There was a problem hiding this comment.
InfiniCore是InfiniLM的依赖，在安装InfiniLM之前是不是应该先调check_infinicore检查一下呢？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
统一脚本管理，支持推理、通信测试的一体化运行
Changes
Test Results