Added logic to check input type for Block name#65
Open
Chsudeepta wants to merge 12 commits intomainfrom
Open
Conversation
rerpha
previously approved these changes
Oct 15, 2025
Comment on lines
90
to
95
| with self.assertRaises(TypeError) as context: | ||
| self.genie_waitfor.start_waiting(block=10) | ||
| self.assertEqual( | ||
| str(context.exception), | ||
| "First argument must be a valid block name or None, not {}".format(10), | ||
| ) |
Contributor
There was a problem hiding this comment.
we install pytest as a dev dependency in genie, so you don't need to try and patch the sys module here (which is also not very good practice and we should be using mocks instead). Instead you can use
with pytest.raises(TypeError, match="some error message printed by the exception"):
Contributor
|
whoops - i meant to hit comment/request changes - please see review comments. |
Contributor
Author
|
The pyright issue has been bypassed because the offensive piece is to cover the case in the code change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
This addresses the issue: 8850
To test
Acceptance criteria
Code Review