Skip to content

[FIX] #47001 UI: Reimplements legacy presentation table important field listing#10993

Open
matheuszych wants to merge 1 commit intoILIAS-eLearning:release_11from
matheuszych:ui/47001
Open

[FIX] #47001 UI: Reimplements legacy presentation table important field listing#10993
matheuszych wants to merge 1 commit intoILIAS-eLearning:release_11from
matheuszych:ui/47001

Conversation

@matheuszych
Copy link
Contributor

https://mantis.ilias.de/view.php?id=47001

Aims to reimplement legacy presentation table important field listing.
@oliversamoila @thojou

@oliversamoila oliversamoila self-requested a review January 27, 2026 11:14
@BettyFromHH BettyFromHH added the css/html Pull requests that propose changes to CSS/SCSS or HTML files. label Feb 2, 2026
Copy link
Contributor

@oliversamoila oliversamoila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello together,
from a UX and UI perspective, the result looks good. Thank you very much for your contribution.
I'm forwarding this to @thibsy for code review. He may contact you with change requests or incorporate the changes directly (That includes cherry picking too.)

Kind regards,
@oliversamoila (as UI coordinator)

@oliversamoila oliversamoila assigned thibsy and unassigned oliversamoila Feb 2, 2026
@thibsy thibsy added the accessibility Pull requests that propose A11Y changes. label Feb 13, 2026
Copy link
Contributor

@thibsy thibsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matheuszych,

Thx a lot for your contribution to the UI framework!

Actually, I believe this makes accessibility worse than before. We should avoid actual characters like | for separation of properties, or at least make them invisible to assistive technologies. To improve accessibility and hereby usability, I think we should use a description list element, which seems semantically correct here. @Annett7811 please correct me if I am wrong.

Please implement the following changes:

  • Description list: please implement the presentation table header fields, and its label and value pairs, using the appropriate description list elements.

Kind regards,
@thibsy (as UI coordinator)

@matheuszych
Copy link
Contributor Author

Hallo @thibsy ,

thank you for your feedback. I adjusted the code accordingly. Please take a look again.

Best regards
@matheuszych

@Annett7811
Copy link

Hello!

@thibsy: In my opinion, switching to a semantic implementation using description lists (dl, dt, dd) makes sense here. The previous solution with separators such as “|” is purely visual and not recommended from an accessibility perspective.
I therefore support the proposed implementation.

Best regards
Annett

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility Pull requests that propose A11Y changes. bugfix css/html Pull requests that propose changes to CSS/SCSS or HTML files. kitchen sink

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants