Skip to content

feat(Account Management): add new service to the project#328

Merged
pyrooka merged 1 commit intoIBM:mainfrom
PureMathematics:add-am-v4
Feb 27, 2026
Merged

feat(Account Management): add new service to the project#328
pyrooka merged 1 commit intoIBM:mainfrom
PureMathematics:add-am-v4

Conversation

@PureMathematics
Copy link
Contributor

@PureMathematics PureMathematics commented Feb 26, 2026

PR summary

onboarding AM service and introduce new v4 apis.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No
➜  platform-services-node-sdk git:(add-am-v4) ✗ npx jest test/integration/account-management.v4.test.js
 PASS  test/integration/account-management.v4.test.js
--------------------|---------|----------|---------|---------|-------------------
File                | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
--------------------|---------|----------|---------|---------|-------------------
All files           |   93.61 |    66.66 |     100 |   93.47 |                   
 account-management |   91.89 |    66.66 |     100 |   91.66 |                   
  v4.ts             |   91.89 |    66.66 |     100 |   91.66 | 70,90,118         
 lib                |     100 |      100 |     100 |     100 |                   
  common.ts         |     100 |      100 |     100 |     100 |                   
--------------------|---------|----------|---------|---------|-------------------

Test Suites: 1 passed, 1 total
Tests:       2 passed, 2 total
Snapshots:   0 total
Time:        1.064 s, estimated 2 s
Ran all test suites matching /test\/integration\/account-management.v4.test.js/i.
➜  platform-services-node-sdk git:(add-am-v4) ✗ npx jest test/unit/account-management.v4.test.js 
 PASS  test/unit/account-management.v4.test.js
--------------------|---------|----------|---------|---------|-------------------
File                | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
--------------------|---------|----------|---------|---------|-------------------
All files           |     100 |    91.66 |     100 |     100 |                   
 account-management |     100 |    91.66 |     100 |     100 |                   
  v4.ts             |     100 |    91.66 |     100 |     100 | 86                
 lib                |     100 |      100 |     100 |     100 |                   
  common.ts         |     100 |      100 |     100 |     100 |                   
--------------------|---------|----------|---------|---------|-------------------

Test Suites: 1 passed, 1 total
Tests:       8 passed, 8 total
Snapshots:   0 total
Time:        0.794 s
Ran all test suites matching /test\/unit\/account-management.v4.test.js/i.

Other information

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2026

CLA assistant check
All committers have signed the CLA.

@PureMathematics PureMathematics force-pushed the add-am-v4 branch 4 times, most recently from 68b185a to 1a2995a Compare February 26, 2026 20:31
@pyrooka pyrooka self-requested a review February 27, 2026 07:43
@pyrooka pyrooka self-assigned this Feb 27, 2026
@pyrooka pyrooka changed the title (feat Account Management) add new v4 api feat(Account Management): add new service to the project Feb 27, 2026
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question before approving, but the code changes look good!

README.md Outdated

Service Name | Import Path
--- | ---
[Account Management](https://cloud.ibm.com/apidocs/account-management) | @ibm-cloud/platform-services/account-management/v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this URL point to the test cloud - like in the other PRs?

Suggested change
[Account Management](https://cloud.ibm.com/apidocs/account-management) | @ibm-cloud/platform-services/account-management/v4
[Account Management](https://test.cloud.ibm.com/apidocs/account-management) | @ibm-cloud/platform-services/account-management/v4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch. Updated

Signed-off-by: David <David.Lim0305@ibm.com>
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pyrooka pyrooka merged commit 07e8936 into IBM:main Feb 27, 2026
8 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Feb 27, 2026
# [0.82.0](v0.81.3...v0.82.0) (2026-02-27)

### Features

* **Account Management:** add new service to the project ([#328](#328)) ([07e8936](07e8936))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.82.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants