Open
Conversation
aram356
requested changes
Feb 13, 2026
aram356
requested changes
Feb 16, 2026
Collaborator
aram356
left a comment
There was a problem hiding this comment.
Thanks for making changes. Few more things introduced with recent changes that needs addressing.
| } | ||
|
|
||
| fn default_allowed_context_keys() -> Vec<String> { | ||
| vec!["permutive_segments".to_string()] |
| let allowed = &settings.auction.allowed_context_keys; | ||
| let mut context = HashMap::new(); | ||
| if let Some(ref config) = body.config { | ||
| if let Some(obj) = config.as_object() { |
Collaborator
There was a problem hiding this comment.
🔧 Use HashSet in place of loop
| #[must_use] | ||
| pub fn build_url_with_context_params( | ||
| base_url: &str, | ||
| context: &HashMap<String, serde_json::Value>, |
Collaborator
There was a problem hiding this comment.
❓ Should we use BTreeMap to preserve order
| fn serialize_context_value(value: &serde_json::Value) -> String { | ||
| match value { | ||
| serde_json::Value::Array(arr) => arr | ||
| .iter() |
Collaborator
There was a problem hiding this comment.
❓ Should we have concrete types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes Permutive audience segments from the browser through to the ad server mediation endpoint, enabling segment-targeted ad decisioning.
Changes
Closes #132
How to Manually Test
Load the page with the tsjs tag. In the DevTools Console, filter for context — you should see a log like:
requestAds: payload { units: N, contextKeys: ["permutive_segments"] }
Verify segments are sent to the server
Open DevTools Network tab and filter for /auction.
Trigger an ad request.
Inspect the /auction POST request body — the config object should contain: