Added new template for combined firstParty and Enforcer lambdas#3
Open
EldarHuman wants to merge 1 commit intomainfrom
Open
Added new template for combined firstParty and Enforcer lambdas#3EldarHuman wants to merge 1 commit intomainfrom
EldarHuman wants to merge 1 commit intomainfrom
Conversation
ori-gold-px
reviewed
Jul 30, 2024
Contributor
There was a problem hiding this comment.
I would suggest reorganizing the files and directories for clarity. What I might do is have the most basic usage of our library in the src directory and then have another sub-folder for additional examples (combined enforcer + first party, async config, etc) that won't be compiled.
src/
- HumanFirstPartyLambda
- HumanEnforceLambda
- HumanActivitiesLambda
- code_samples/
- EnforceAndFirstPartyOriginRequestLambda
- AsyncConfigLambdaExample
- ...
Or something like this.
Comment on lines
+18
to
+19
| const enforcer = HumanSecurityEnforcer.initialize(config); | ||
| const firstParty = HumanSecurityFirstParty.initialize(config); |
Contributor
There was a problem hiding this comment.
Should be initialized once instead of on every invocation of the handler. Store them in global variables and reuse them.
| # variable declarations | ||
| build_dir=dist | ||
| lambdas=( PXEnforcer PXFirstParty PXActivities ) | ||
| lambdas=( PXEnforcer PXFirstParty PXActivities PXCombined_Enforcer_FirstParty) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.