Jinjava 3.0: Migrate JinjavaConfig to Immutables#1290
Draft
jasmith-hs wants to merge 1 commit intobase-jinjava-3.0from
Draft
Jinjava 3.0: Migrate JinjavaConfig to Immutables#1290jasmith-hs wants to merge 1 commit intobase-jinjava-3.0from
jasmith-hs wants to merge 1 commit intobase-jinjava-3.0from
Conversation
jasmith-hs
force-pushed
the
base-jinjava-3.0
branch
from
923a276 to
0052c9d
Compare
jasmith-hs
force-pushed
the
3.0/immutable-config
branch
from
dd87116 to
cda2230
Compare
jasmith-hs
force-pushed
the
base-jinjava-3.0
branch
from
0052c9d to
370a038
Compare
jasmith-hs
force-pushed
the
3.0/immutable-config
branch
from
cda2230 to
ebeb04f
Compare
jasmith-hs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1288.
Migrates
JinjavaConfigand related builder-pattern classes (includingLegacyOverridesandErrorHandlingStrategy) to use@Value.Immutable. This removes ~400 lines of hand-written builder boilerplate and makes configuration objects safer to use throughout the codebase.