feat: Enhance image name handling and add unit tests for absolute image references#70
Merged
GordonBeeming merged 1 commit intomainfrom Mar 3, 2026
Merged
feat: Enhance image name handling and add unit tests for absolute image references#70GordonBeeming merged 1 commit intomainfrom
GordonBeeming merged 1 commit intomainfrom
Conversation
…ge references Customizing the environment and container images Fixes #68
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #68 by allowing users to specify a fully-qualified container image reference (e.g., from a private registry or Docker Hub) without the app automatically prefixing it with ghcr.io/gordonbeeming/copilot_here, and adds unit tests around absolute image handling.
Changes:
- Add
ContainerRunner.IsAbsoluteImageReference(...)and update image-name resolution to return absolute image references unchanged. - Update
GitHubCopilotToolandEchoToolto respect absolute image references passed via the tag/config. - Add unit tests verifying absolute image references are returned “as-is”.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
app/Infrastructure/ContainerRunner.cs |
Adds absolute-image detection and adjusts GetImageName to avoid prefixing full image refs. |
app/Infrastructure/AirlockRunner.cs |
Allows Airlock mode to accept an absolute app image reference. |
app/Tools/GitHubCopilotTool.cs |
Returns absolute image refs unchanged instead of constructing a copilot-* tag. |
app/Tools/EchoTool.cs |
Same absolute image behavior as GitHub Copilot tool. |
tests/CopilotHere.UnitTests/ContainerRunnerImageTests.cs |
New tests for absolute-image detection + GetImageName. |
tests/CopilotHere.UnitTests/GitHubCopilotToolTests.cs |
Adds tests for absolute image refs in tool image naming. |
tests/CopilotHere.UnitTests/EchoToolTests.cs |
Adds tests for absolute image refs in tool image naming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customizing the environment and container images
Fixes #68