Add support for webhook notification channels #2249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilv-g
force-pushed
the
slack-webhook
branch
2 times, most recently
from
8c446e8 to
005fc11
Compare
High level changes: - Added support for creating and updating notification channels - Only Slack webhook URLs are supported for now, but the changes are meant to be generic to support other types in the future - Max of 25 notification channels per user
neilv-g
force-pushed
the
slack-webhook
branch
from
005fc11 to
a935288
Compare
jcscottiii
reviewed
Feb 12, 2026
Comment on lines
+1873
to
+1877
| type: | ||
| type: string | ||
| enum: | ||
| - webhook |
Collaborator
There was a problem hiding this comment.
Suggested change
| type: | |
| type: string | |
| enum: | |
| - webhook |
Let's get rid of the high level type variable. Also, in a follow up, we can get rid of the high level type key for the object and rely on your discriminator type in the config.
jcscottiii
reviewed
Feb 12, 2026
| config: | ||
| description: Configuration specific to the channel type. | ||
| oneOf: | ||
| - $ref: '#/components/schemas/EmailConfig' |
Collaborator
There was a problem hiding this comment.
For now, we don't want emails to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High level changes: