Skip to content

fix: Require web3>=7.0.0 to avoid breaking API changes#27

Merged
eureka-cpu merged 1 commit intomainfrom
eureka-cpu/fix-web3-requirement
Sep 9, 2025
Merged

fix: Require web3>=7.0.0 to avoid breaking API changes#27
eureka-cpu merged 1 commit intomainfrom
eureka-cpu/fix-web3-requirement

Conversation

@eureka-cpu
Copy link
Contributor

Fixes a bug that some users were facing that was pulling in an outdated version of the web3 library that uses different naming conventions than the exposed API from the SDK.

@eureka-cpu eureka-cpu requested a review from r-vdp September 5, 2025 21:11
@eureka-cpu eureka-cpu self-assigned this Sep 5, 2025
@eureka-cpu eureka-cpu added the bug Something isn't working label Sep 5, 2025
@eureka-cpu
Copy link
Contributor Author

@r-vdp I was running into some issues with uv sync. I'm not well versed with python dependency management, so unsure if it's just a skill issue on my part or if there's a problem with the build env:

$ uv sync
Resolved 69 packages in 0.79ms
  × Failed to build `golem-base-sdk @ file:///home/eureka/Code/golem-base/python-sdk`
  ├─▶ The build backend returned an error
  ╰─▶ Call to `flit_core.buildapi.build_editable` failed (exit status: 1)

      [stderr]
      Traceback (most recent call last):
        File "<string>", line 8, in <module>
      ModuleNotFoundError: No module named 'flit_core'

      hint: This usually indicates a problem with the package or the build environment.
FAIL

@eureka-cpu eureka-cpu requested a review from draganm September 5, 2025 21:17
@r-vdp
Copy link
Member

r-vdp commented Sep 6, 2025

@r-vdp I was running into some issues with uv sync. I'm not well versed with python dependency management, so unsure if it's just a skill issue on my part or if there's a problem with the build env:

$ uv sync
Resolved 69 packages in 0.79ms
  × Failed to build `golem-base-sdk @ file:///home/eureka/Code/golem-base/python-sdk`
  ├─▶ The build backend returned an error
  ╰─▶ Call to `flit_core.buildapi.build_editable` failed (exit status: 1)

      [stderr]
      Traceback (most recent call last):
        File "<string>", line 8, in <module>
      ModuleNotFoundError: No module named 'flit_core'

      hint: This usually indicates a problem with the package or the build environment.
FAIL

What python version are you using? Maybe we need to relax the version bound for flit_core in pyproject.toml to match the minimal python version that we require.

@eureka-cpu
Copy link
Contributor Author

@r-vdp I was running into some issues with uv sync. I'm not well versed with python dependency management, so unsure if it's just a skill issue on my part or if there's a problem with the build env:

$ uv sync
Resolved 69 packages in 0.79ms
  × Failed to build `golem-base-sdk @ file:///home/eureka/Code/golem-base/python-sdk`
  ├─▶ The build backend returned an error
  ╰─▶ Call to `flit_core.buildapi.build_editable` failed (exit status: 1)

      [stderr]
      Traceback (most recent call last):
        File "<string>", line 8, in <module>
      ModuleNotFoundError: No module named 'flit_core'

      hint: This usually indicates a problem with the package or the build environment.
FAIL

What python version are you using? Maybe we need to relax the version bound for flit_core in pyproject.toml to match the minimal python version that we require.

Just whichever version comes with the devShell

@eureka-cpu eureka-cpu merged commit 4012ebe into main Sep 9, 2025
1 check passed
@eureka-cpu eureka-cpu deleted the eureka-cpu/fix-web3-requirement branch September 9, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants