Open
Conversation
|
is the code AI generated? I can see some familiarity. Sorry if I am wrong. |
Author
The code tries to follow the same (similar) format of the Quadratic Optimiser as implemented by a GSoC 2024 participant. I've referred to the usual LLMs to ensure the code written tries to avoid errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @TolisChal, @cbachela
I've attempted to integrate the Linear Optimization class (
LinearProgram) intoqp_problems.py, which currently consists the existing quadratic optimizer. I've tried to maintain the same code structure asQuadraticProgram.The code executes but results in two failed tests and two errors in the current test run (
src/test_linear_program.py). The test file is currently undersrc; I didn't want to worry about relative imports yet since I wanted to establish a foundation first. If everything looks good, I'll move it to the test directory.If you could review it and provide feedback on whether I'm heading in the right direction, I'll make the necessary adjustments.
Thanks!