Skip to content

Fix/oxlint#299

Merged
BotellaA merged 91 commits intonextfrom
fix/oxlint
Feb 18, 2026
Merged

Fix/oxlint#299
BotellaA merged 91 commits intonextfrom
fix/oxlint

Conversation

@MaxNumerique
Copy link
Contributor

No description provided.

@MaxNumerique MaxNumerique requested a review from BotellaA February 5, 2026 14:10
@MaxNumerique MaxNumerique marked this pull request as ready for review February 5, 2026 14:10
const { id } = defineProps({
id: { type: String, required: true },
})

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplification des expressions booléennes, ternaires non utiles

Comment on lines 32 to 35

await Promise.all(
removed.map((item) => dataStyleStore.setVisibility(item.id, false)),
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promise.all pour s'assurer que toutesles mises à jour de visibilité sont terminées avant de faire le rendu

const internal_files = ref(props.files)
const auto_upload = ref(props.auto_upload)
const internal_files = ref(files)
const internal_auto_upload = ref(auto_upload)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renommage de la ref interne pour éviter la confusion avec la prop

}
const promise_array = internal_files.value.map((file) =>
upload_file({ route: schema.$id, file }),
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supprime l'enrobagee des promesses redondantes puisque upload_file en retourne déjà une.
.map() et Promise.all rend le traitement des fichiers asynchrone et élimine la gestion manuelle des réussites/échecs dans une boucle

Comment on lines 25 to 36
await Promise.all(
stores.map(async (store) => {
if (!store.exportStores) return
const storeId = store.$id
try {
snapshot[storeId] = await store.exportStores(params)
exportCount += 1
} catch (error) {
console.error(`[AppStore] Error exporting store "${storeId}":`, error)
}
}),
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combinaison de Promise.all et map() pour se passer de la boucle

MaxNumerique and others added 23 commits February 16, 2026 16:56
@BotellaA BotellaA merged commit b6206ef into next Feb 18, 2026
25 of 26 checks passed
@BotellaA BotellaA deleted the fix/oxlint branch February 18, 2026 09:08
@JulienChampagnol
Copy link
Member

🎉 This PR is included in version 10.3.1-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments