Open
Conversation
Move the shared VCard parsing classes from the individual sample folders to the Shared project so both ImageExtractorSample and CardholderFieldsExtractorSample use the same implementation.
Add field to store component reference, add Unregister in Unload, and add ApplicationType check for SecurityDesk and ConfigTool.
Add field to store component reference, add Unregister in Unload, and add ApplicationType check for SecurityDesk and ConfigTool.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors workspace SDK samples to improve code organization and resource management. The changes consolidate shared VCard functionality and enhance module lifecycle handling.
Changes:
- Moved VCard-related classes from ImageExtractorSample to shared project for reuse across samples
- Added proper initialization guards and cleanup logic in module Load/Unload methods
- Improved code readability with better variable naming and control flow
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| VCardReader.cs | Removed from ImageExtractorSample (moved to shared) |
| VCard.cs | Removed from ImageExtractorSample (moved to shared) |
| SampleModule.cs (ImageExtractorSample) | Added application type checks, field storage, and proper cleanup |
| SampleImageExtractor.cs | Improved variable naming and control flow readability |
| SampleModule.cs (CardholderFieldsExtractorSample) | Added application type checks, field storage, and proper cleanup |
| SampleCardholderFieldsExtractor.cs | Improved variable naming and control flow readability |
| CardholderFieldsExtractorSample.csproj | Added reference to shared project |
| Shared.projitems | Added VCard and VCardReader to shared compilation |
| Genetec.Dap.CodeSamples.sln | Added shared items import mapping |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.