Fixed invalid state after data was successfully parsed.#9
Open
UltraCoderRU wants to merge 1 commit intoFooBarWidget:masterfrom
Open
Fixed invalid state after data was successfully parsed.#9UltraCoderRU wants to merge 1 commit intoFooBarWidget:masterfrom
UltraCoderRU wants to merge 1 commit intoFooBarWidget:masterfrom
Conversation
Contributor
|
Hello. Please consider merging this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
I tried to use this parser in my project and found invalid behaviour.
When parser meets last boundary, it just exits from feed function without updating its members. As a result parser.stoped() == false and value return from parser.feed() is not equal to full size of data.
Best regards.