Skip to content

Drop React FAB dependency by replacing ReactAdapter with vanilla component #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Totremont wants to merge 32 commits into
base: master
Choose a base branch
from
+1,240 −545

WIP: combine resizing logic into single file and method

2d7ad6a
Select commit
Loading
Failed to load commit list.
Open

Drop React FAB dependency by replacing ReactAdapter with vanilla component #58

WIP: combine resizing logic into single file and method
2d7ad6a
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 12, 2026 in 26s

Quality Gate failed

Failed conditions
5.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 20 in src/main/resources/META-INF/frontend/fc-chat-assistant-movement.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZzYebj-fTRZnG-drPye&open=AZzYebj-fTRZnG-drPye&pullRequest=58

Check warning on line 36 in src/main/resources/META-INF/frontend/fc-chat-assistant-resize.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZziem3kM9Y8niPctjT2&open=AZziem3kM9Y8niPctjT2&pullRequest=58

Check warning on line 21 in src/main/resources/META-INF/frontend/fc-chat-assistant-movement.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZzYebj-fTRZnG-drPyf&open=AZzYebj-fTRZnG-drPyf&pullRequest=58

Check warning on line 183 in src/main/resources/META-INF/frontend/fc-chat-assistant-resize.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZziem3kM9Y8niPctjT8&open=AZziem3kM9Y8niPctjT8&pullRequest=58

Check warning on line 463 in src/main/java/com/flowingcode/vaadin/addons/chatassistant/ChatAssistant.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this array creation and simply pass the elements. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZzYeboufTRZnG-drPzs&open=AZzYeboufTRZnG-drPzs&pullRequest=58

Check warning on line 118 in src/main/java/com/flowingcode/vaadin/addons/chatassistant/ChatAssistant.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Provide the parametrized type for this generic. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZzYeboufTRZnG-drPzk&open=AZzYeboufTRZnG-drPzk&pullRequest=58

Check warning on line 22 in src/main/resources/META-INF/frontend/fc-chat-assistant-movement.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZzYebj-fTRZnG-drPyg&open=AZzYebj-fTRZnG-drPyg&pullRequest=58

Check warning on line 56 in src/main/resources/META-INF/frontend/fc-chat-assistant-resize.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZziem3kM9Y8niPctjT4&open=AZziem3kM9Y8niPctjT4&pullRequest=58

Check warning on line 55 in src/main/resources/META-INF/frontend/fc-chat-assistant-resize.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZziem3kM9Y8niPctjT3&open=AZziem3kM9Y8niPctjT3&pullRequest=58

Check warning on line 517 in src/main/java/com/flowingcode/vaadin/addons/chatassistant/ChatAssistant.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused private "refreshContent" method. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZzYeboufTRZnG-drPzp&open=AZzYeboufTRZnG-drPzp&pullRequest=58

Check warning on line 572 in src/main/java/com/flowingcode/vaadin/addons/chatassistant/ChatAssistant.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this array creation and simply pass the elements. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZzYeboufTRZnG-drPzu&open=AZzYeboufTRZnG-drPzu&pullRequest=58

Check warning on line 202 in src/main/resources/META-INF/frontend/fc-chat-assistant-resize.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZziem3kM9Y8niPctjT9&open=AZziem3kM9Y8niPctjT9&pullRequest=58

Check warning on line 109 in src/main/java/com/flowingcode/vaadin/addons/chatassistant/ChatAssistant.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Provide the parametrized type for this generic. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZzYeboufTRZnG-drPzj&open=AZzYeboufTRZnG-drPzj&pullRequest=58

Check warning on line 122 in src/main/java/com/flowingcode/vaadin/addons/chatassistant/ChatAssistant.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Provide the parametrized type for this generic. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZzYeboufTRZnG-drPzl&open=AZzYeboufTRZnG-drPzl&pullRequest=58

Check warning on line 655 in src/main/java/com/flowingcode/vaadin/addons/chatassistant/ChatAssistant.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZzYeboufTRZnG-drPzx&open=AZzYeboufTRZnG-drPzx&pullRequest=58

Check warning on line 239 in src/main/resources/META-INF/frontend/fc-chat-assistant-resize.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZziem3kM9Y8niPctjT_&open=AZziem3kM9Y8niPctjT_&pullRequest=58

Check warning on line 62 in src/main/resources/META-INF/frontend/fc-chat-assistant-movement.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZzenQSEaiJdbcjuSx9-&open=AZzenQSEaiJdbcjuSx9-&pullRequest=58

Check failure on line 231 in src/main/java/com/flowingcode/vaadin/addons/chatassistant/ChatAssistant.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "var(--lumo-font-size-xs)" 7 times. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZzYeboufTRZnG-drPzo&open=AZzYeboufTRZnG-drPzo&pullRequest=58

Check warning on line 598 in src/main/java/com/flowingcode/vaadin/addons/chatassistant/ChatAssistant.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this array creation and simply pass the elements. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZzYeboufTRZnG-drPzw&open=AZzYeboufTRZnG-drPzw&pullRequest=58

Check warning on line 596 in src/main/java/com/flowingcode/vaadin/addons/chatassistant/ChatAssistant.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this array creation and simply pass the elements. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZzYeboufTRZnG-drPzv&open=AZzYeboufTRZnG-drPzv&pullRequest=58

Check warning on line 22 in src/main/resources/META-INF/frontend/fc-chat-assistant-resize.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZziem3kM9Y8niPctjTz&open=AZziem3kM9Y8niPctjTz&pullRequest=58

Check warning on line 255 in src/main/resources/META-INF/frontend/fc-chat-assistant-resize.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZziem3kM9Y8niPctjUA&open=AZziem3kM9Y8niPctjUA&pullRequest=58

Check warning on line 24 in src/main/resources/META-INF/frontend/fc-chat-assistant-resize.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZziem3kM9Y8niPctjT1&open=AZziem3kM9Y8niPctjT1&pullRequest=58

Check warning on line 23 in src/main/resources/META-INF/frontend/fc-chat-assistant-resize.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZziem3kM9Y8niPctjT0&open=AZziem3kM9Y8niPctjT0&pullRequest=58

Check warning on line 258 in src/main/resources/META-INF/frontend/fc-chat-assistant-resize.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_ChatAssistant&issues=AZziem3kM9Y8niPctjUD&open=AZziem3kM9Y8niPctjUD&pullRequest=58
View more details on SonarQubeCloud