Fix Power Management "Perform Immediately" bug.#780
Open
jpugliese wants to merge 1 commit intoFOGProject:dev-branchfrom
Open
Fix Power Management "Perform Immediately" bug.#780jpugliese wants to merge 1 commit intoFOGProject:dev-branchfrom
jpugliese wants to merge 1 commit intoFOGProject:dev-branchfrom
Conversation
When pmOndemand=1, the backend still requires pmMin/pmHour/etc. This patch populates time fields before save(), preventing "Required database field is empty: min". Tested on FOG 1.5.x with shutdown and reboot tasks.
Member
|
Thank you for your contribution! |
mastacontrola
added a commit
that referenced
this pull request
Mar 2, 2026
… does not require this. This should be all thats necessary to address the real problem provided from #780.
Member
|
So I have added code that should prevent the need to do this. Your method, while a work around doesn't actually fix the real problem. Your method effectively makes the Power On task a yearly task (whenever the dow matches the dom). (So a ~ 4 year automated task.) Basically the problem is we added coded to prevent updating things if a "required" database field isn't defined. This has some unexpected side effects while we fix the underlying code appropriately. Please review with the latest code in dev-branch (not your patch please) and validate that Powermanagement Ondemand items works appropriately now? Thank you and apologies on the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pmOndemand=1, the backend still requires pmMin/pmHour/etc. This patch populates time fields before save(), preventing "Required database field is empty: min".
Tested on FOG 1.5.x with shutdown and reboot tasks.