[CP Staging] Revert "Enable merchant rules"#82248
Merged
Conversation
melvin-bot
bot
requested review from
heyjennahay
and removed request for
a team
lakchote
changed the title
MonilBhavsar
approved these changes
Feb 12, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9794781a63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+106
to
+107
| if (isProduction) { | ||
| return null; |
There was a problem hiding this comment.
This change only removes the MerchantRulesSection entry point in production, but it does not actually disable the merchant-rule flow: the screens are still registered in src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx (e.g., SCREENS.WORKSPACE.RULES_MERCHANT_NEW / ...EDIT), and MerchantRulePageBase has no production guard. In production, anyone with a bookmarked/deep-linked merchant-rule URL can still open create/edit pages and submit rules, so the revert is incomplete.
Useful? React with 👍 / 👎.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Contributor
|
Straight revert not emergency |
OSBotify
pushed a commit
that referenced
this pull request
Feb 12, 2026
…Lock [CP Staging] Revert "Enable merchant rules" (cherry picked from commit 844a7cc) (cherry-picked to staging by lakchote)
Contributor
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.3.17-9 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.17-9 🚀
|
Contributor
|
🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.3.18-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #81033
$ #82241
$ #82228
$ #82245
$ #82225