test crop svg

[nkdengineer]

Explanation of Change

Fixed Issues

$ #79961
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[nkdengineer]

@shawnborton @srikarparsi I created a new branch and only added the crop SVG and used it in place of roate icon to see if it can work. Please help to kick off a build. I will test on my device in the adhoc build. Will ping you again if it works.

[srikarparsi]

Awesome, just ran the build

[github-actions]

🚧 @srikarparsi has triggered a test Expensify/App build. You can view the workflow run here.

[nkdengineer]

@srikarparsi The icon still doesn't show in the adhoc build

[srikarparsi]

Can you try replacing the contents of @assets/images/rotate-image.svg with the contents of crop.svg and nothing else?

And then I can rerun the AdHoc. Just to make sure that it is only the svg code that is being changed.

[nkdengineer]

Can you try replacing the contents of @assets/images/rotate-image.svg with the contents of crop.svg and nothing else?

@srikarparsi We tried this in the previous PR, and it works. It only doesn't work if we paste any content to crop.svg

[shawnborton]

Why don't we try just using a different name for crop? Like imagecrop.svg or something, and then call ImageCrop for the icon name?

[nkdengineer]

@shawnborton I tried the new name like crop-image.svg, crop-icon.svg in the previous PR. and called the icon like CropIcon/CropImage but it still doesn't work.

[nkdengineer]

But let me try again here.

[shawnborton]

Try leading with a different word than crop

[shawnborton]

So like ImageCrop as I am suggesting.

[nkdengineer]

@shawnborton Updated your suggestion. Please help with a build.

[github-actions]

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82224.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-163609763bb99491da77b2e786a0d276084e2b8a-0066f7613d4b4fb5784c789c207bdc346d2a34c6/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-163609763bb99491da77b2e786a0d276084e2b8a-f312ea300e26eb9e1aea9d7020a1d26ac427a323/index.html

Web 🕸️
https://82224.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[shawnborton]

Not sure how to test this one?

[nkdengineer]

I'm testing this.

[nkdengineer]

Still doesn't work.

[nkdengineer]

I'm testing in this place.

[shawnborton]

Ah got it, yeah it's still not showing up.

[nkdengineer]

This confirms the issue is not the SVG content or format at all -- it's a native asset bundling problem with new files. It's not a file count limit or file name issue.
Here's what's happening:

Release/production builds (installed on physical device from CI/TestFlight/etc.): assets are bundled into the native binary at build time. The native build cache or the bundler may not pick up the new file without a clean rebuild.
When you copy content into an existing file, the build system already knows about that file and updates it. A brand-new file isn't in the cached asset manifest.

Since this project uses the HybridApp architecture (builds from Mobile-Expensify), if the build that goes to physical devices comes from CI/CD via the Mobile-Expensify submodule, you also need to ensure:
The new imagecrop.svg file is committed and pushed to the branch
The Mobile-Expensify build picks up the latest App submodule with the new asset
The CI/CD pipeline does a clean build (not using a cached native binary)
TL;DR: Not a file limit, not a filename issue, not an SVG content issue. It's a stale native build cache that doesn't include the new asset file. A clean rebuild will fix it.

@srikarparsi Just got some information from AI. Not sure if we can do anything with this?

[nkdengineer]

@shawnborton Please give me another try with new name.

[github-actions]

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82224.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-113d1b3b76719286d9eb1331d0a38ca4798bf640-0066f7613d4b4fb5784c789c207bdc346d2a34c6/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-113d1b3b76719286d9eb1331d0a38ca4798bf640-f312ea300e26eb9e1aea9d7020a1d26ac427a323/index.html

Web 🕸️
https://82224.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[shawnborton]

Still nothing.

[nkdengineer]

The same from me. Maybe we need find another way cc @srikarparsi