-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[No QA] Rename Zenefits to TriNet #82209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updating Zenefits w/ new name TriNet
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@arosiclair @CortneyOfstad One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
|
|
||
| --- | ||
|
|
||
| # Prerequisites |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readability violation: Missing breadcrumb path after the H1 heading. Add the navigation path for better user orientation.
This section should include where users can find prerequisite information or settings.
docs/articles/new-expensify/billing-and-subscriptions/Plan-types-and-pricing.md
Show resolved
Hide resolved
HelpDot Documentation ReviewOverall AssessmentThis PR renames the Zenefits integration to TriNet across documentation files. The changes are straightforward and consist primarily of a find-and-replace operation. The documentation maintains consistent quality throughout, with clear structure, proper formatting, and appropriate content for both technical accuracy and user readability. Scores Summary
Key FindingsPositive Aspects:
Issues Identified:
RecommendationsCritical Actions Required:
Optional Improvements:
Files Reviewed
Overall Score: 8.7/10The documentation changes are well-executed with consistent application of the rename across all content. The main concerns are technical (file naming and metadata format) rather than content quality issues. Once the file is properly renamed and the title field is corrected, this will be excellent documentation. Note: Detailed line-by-line feedback would focus on the file naming mismatch and title format issues mentioned above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d69bd153d4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| https://community.expensify.com/discussion/5677/deep-dive-how-expensify-protects-your-information/,https://help.expensify.com/articles/new-expensify/settings/Encryption-and-Data-Security | ||
| https://help.expensify.com/articles/new-expensify/reports-and-expenses/Split-Personal-Expenses,https://help.expensify.com/articles/new-expensify/reports-and-expenses/Create-an-Expense#split-personal-expenses | ||
| https://help.expensify.com/articles/new-expensify/connections/sage-intacct/Sage-Intacct-Troubleshooting,https://help.expensify.com/new-expensify/hubs/connections/sage-intacct | ||
| https://help.expensify.com/articles/expensify-classic/connections/Zenefits,https://help.expensify.com/articles/expensify-classic/connections/TriNet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redirect Zenefits URL to an existing article path
This redirect now sends .../connections/Zenefits to .../connections/TriNet, but there is no corresponding TriNet article in this commit (the only file in that hub is still docs/articles/expensify-classic/connections/Zenefits.md). I checked createDocsRoutes.ts, and it builds article hrefs from filenames (filename.replace('.md', '')), so the generated route remains /Zenefits; after deploy, this redirect will forward users to a non-existent page instead of the renamed content.
Useful? React with 👍 / 👎.
|
A preview of your ExpensifyHelp changes have been deployed to https://5276f29d.helpdot.pages.dev ⚡️ Updated articles: |
See: https://github.com/Expensify/Expensify/issues/598902#issuecomment-3882874170