[Odometer] Refactor IOURequestStepDistanceOdometer to use handleMoneyRequestStepDistanceNavigation #82204

jakubkalinski0 · 2026-02-11T22:26:47Z

Explanation of Change

This PR refactors IOURequestStepDistanceOdometer to use the shared handleMoneyRequestStepDistanceNavigation helper (the same flow used by other distance types). The goal is to consolidate navigation and request creation logic in one place, reduce duplication, and ensure odometer follows the same recipient/confirmation behavior as the manual/gps flows. To support odometer specifics, the helper now accepts and forwards odometerStart / odometerEnd.

Add odometer fields to the common navigation helper so they’re passed through track/create paths:

type MoneyRequestStepDistanceNavigationParams = {
    ...
    odometerStart?: number;
    odometerEnd?: number;
    ...
};
...
handleMoneyRequestStepDistanceNavigation({
    ...
    odometerStart,
    odometerEnd,
    ...
});

Replace the odometer navigation/creation flow with a single call to the shared helper. This removes a pretty big chunk of code and aligns behavior across distance tabs.

import {handleMoneyRequestStepDistanceNavigation} from '@libs/actions/IOU/MoneyRequest';
...
if (shouldSkipConfirmation) {
    setShouldEnableDiscardConfirmation(false);
}
handleMoneyRequestStepDistanceNavigation({
    iouType,
    report,
    policy,
    transaction,
    reportID,
    transactionID,
    ...
    manualDistance: calculatedDistance,
    odometerStart: start,
    odometerEnd: end,
    ...
});

Supporting cleanup: remove unused helpers/imports and rely on shared hooks for default policy, self‑DM, and policy moves so odometer inherits the same routing rules as other distance flows.

Fixed Issues

$ #81727
PROPOSAL: N/A

Tests

FAB - green Floating Action Button in the bottom left corner i.e. the global create flow

Go to FAB -> "Track distance" and select the Odometer tab
Enter start/end readings and continue - verify you land on the same recipient/confirmation step as before the change (you can also compare it with the manual distance behavior)
Now create an odometer expense form the workspace chat and verify it works properly and uses the same recipient/confirmation behavior as manual distance. Verify that no recipient page shows when creating odometer expense from any form of chat/report
After you created an odometer expense from the workspace chat (or to the workspace from the FAB) when you go to FAB you should see at the bottom of the menu a "Quick action" which should be showing an odometer expense. Start an Odometer request from the global FAB by pressing this "Quick action", enter readings, and verify you skip recipient selection and land directly on the confirmation tied to that workspace
Now create an odometer expense from 1:1 chat (with another user - not in a workspace chat) - when you go to FAB you should see at the bottom of the menu a "Quick action" which should be showing an odometer expense. Start an Odometer request from "Quick action", enter readings, and verify the request submits without showing the recipient or confirmation step.

Verify that no errors appear in the JS console

Offline tests

Same as tests but force offline in troubleshoot

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-12.at.12.58.02.mov

…stStepDistanceNavigation

codecov · 2026-02-12T10:23:46Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/IOU/MoneyRequest.ts	`98.62% <100.00%> (+<0.01%)`	⬆️
...ou/request/step/IOURequestStepDistanceOdometer.tsx	`0.00% <0.00%> (ø)`
... and 12 files with indirect coverage changes

GCyganek

LGTM 🚀

melvin-bot · 2026-02-12T17:26:31Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-02-12T17:26:31Z

@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…stStepDistanceNavigation

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 098115eda0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/actions/IOU/MoneyRequest.ts

abzokhattab · 2026-02-12T17:51:49Z

Does it need c+ review? Asking since it was requested above

…DistanceNavigation

jakubkalinski0 · 2026-02-12T18:03:08Z

@abzokhattab I guess this question should be directed to @Julesssss

Julesssss · 2026-02-12T20:42:35Z

@DylanDylann has been working with us on all of the Odometer PRs.

DylanDylann · 2026-02-13T08:55:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-13.at.16.08.07.mov

Android: mWeb Chrome

Screen.Recording.2026-02-13.at.16.01.21.mov

iOS: HybridApp

Screen.Recording.2026-02-13.at.16.04.10.mov

iOS: mWeb Safari

Screen.Recording.2026-02-13.at.15.59.22.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-13.at.15.56.46.mov

Refactored odometer page to use handleMoneyRequestStepDistanceNavigation

387b1ce

melvin-bot bot assigned jakubkalinski0 Feb 11, 2026

Merge branch 'main' into jakubkalinski0/Odometer_use_handleMoneyReque…

9608174

…stStepDistanceNavigation

jakubkalinski0 added 2 commits February 12, 2026 17:44

Added odometerDistance to handleMoneyRequestStepDistanceNavigation

ae21b61

Prettier run

098115e

GCyganek approved these changes Feb 12, 2026

View reviewed changes

jakubkalinski0 marked this pull request as ready for review February 12, 2026 17:26

jakubkalinski0 requested review from a team as code owners February 12, 2026 17:26

melvin-bot bot requested review from abzokhattab and jayeshmangwani and removed request for a team February 12, 2026 17:26

melvin-bot bot requested review from heyjennahay and removed request for a team February 12, 2026 17:26

Merge branch 'main' into jakubkalinski0/Odometer_use_handleMoneyReque…

a9019be

…stStepDistanceNavigation

chatgpt-codex-connector bot reviewed Feb 12, 2026

View reviewed changes

src/libs/actions/IOU/MoneyRequest.ts Show resolved Hide resolved

Fix merge conflict

07380bd

Passed odometerDistance to expense creation in handleMoneyRequestStep…

86f89cc

…DistanceNavigation

Julesssss requested review from DylanDylann and removed request for jayeshmangwani February 12, 2026 20:42

DylanDylann approved these changes Feb 13, 2026

View reviewed changes

melvin-bot bot requested a review from Julesssss February 13, 2026 09:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Odometer] Refactor IOURequestStepDistanceOdometer to use handleMoneyRequestStepDistanceNavigation #82204

[Odometer] Refactor IOURequestStepDistanceOdometer to use handleMoneyRequestStepDistanceNavigation #82204

jakubkalinski0 commented Feb 11, 2026 •

edited

Loading

Uh oh!

codecov bot commented Feb 12, 2026 •

edited by github-actions bot

Loading

Uh oh!

GCyganek left a comment

Uh oh!

melvin-bot bot commented Feb 12, 2026

Uh oh!

melvin-bot bot commented Feb 12, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

abzokhattab commented Feb 12, 2026

Uh oh!

jakubkalinski0 commented Feb 12, 2026

Uh oh!

Julesssss commented Feb 12, 2026

Uh oh!

DylanDylann commented Feb 13, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[Odometer] Refactor IOURequestStepDistanceOdometer to use handleMoneyRequestStepDistanceNavigation #82204

Are you sure you want to change the base?

[Odometer] Refactor IOURequestStepDistanceOdometer to use handleMoneyRequestStepDistanceNavigation #82204

Conversation

jakubkalinski0 commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 12, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

GCyganek left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Feb 12, 2026

Uh oh!

melvin-bot bot commented Feb 12, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

abzokhattab commented Feb 12, 2026

Uh oh!

jakubkalinski0 commented Feb 12, 2026

Uh oh!

Julesssss commented Feb 12, 2026

Uh oh!

DylanDylann commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jakubkalinski0 commented Feb 11, 2026 •

edited

Loading

codecov bot commented Feb 12, 2026 •

edited by github-actions bot

Loading

DylanDylann commented Feb 13, 2026 •

edited

Loading