Fixed multiple enchantings on items#108
Open
Postremus wants to merge 1 commit intoEngineHub:masterfrom
Postremus:master
Open
Fixed multiple enchantings on items#108Postremus wants to merge 1 commit intoEngineHub:masterfrom Postremus:master
Postremus wants to merge 1 commit intoEngineHub:masterfrom
Postremus:master
Conversation
Previosly enchantings and the item amount was seperated by a "," I changed the amount to be seperated by a "#"
Member
There was a problem hiding this comment.
I don't think this is the best character to use at the very least. # is a comment character if I recall correctly. Also, this breaks backwards compatibility with various kits, does it not?
I'm pretty sure just from looking at the code here, kits follow their own syntax, so I think the real issues is enchants were never properly implemented for kits.
EDIT: I take that back, it's setting item quantity, and that seems to be all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previosly enchantings and the item amount was seperated by a ","
This causes the ItemUtil.getComamndItem() method to only get one of the enchantments.
I changed the amount to be seperated by a "#"