Replace vue-sweetalert2 with vue-material dialogs#498
Draft
munyanezaarmel wants to merge 6 commits intomainfrom
Draft
Replace vue-sweetalert2 with vue-material dialogs#498munyanezaarmel wants to merge 6 commits intomainfrom
munyanezaarmel wants to merge 6 commits intomainfrom
Conversation
Member
|
Hey @munyanezaarmel Could you provide a bit more context what is happening here? Our overarching goal is to fully remove Could you also add a screenshot how the new way looks like? |
Member
|
Hey @munyanezaarmel Is this change fully removing our dependency on |
Member
|
Hey @munyanezaarmel this looks quite good. Before I review it, can you fix the lint? You need to provide other translations for |
Member
|
Also, what is still missing is to fully uninstall npm uninstall vue-sweetalert2 |
3ae7af8 to
ceb4aac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Replace vue-sweetalert2 with vue-material dialogs
closes: #174
Are there any other side effects of this change that we should be aware of?
Describe how you tested your changes?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.