Draft
Conversation
Collaborator
Author
|
Note to self: Change mixin so that the vanilla behaviour remains the same. |
Owner
|
What's the difference between this and F3+D? |
Collaborator
Author
|
See #dev-general > 💬. |
haykam821
reviewed
Feb 2, 2024
Comment on lines
+121
to
+124
| @Redirect(method = "clear", at = @At(value = "INVOKE", target = "Lnet/minecraft/util/collection/ArrayListDeque;addAll(Ljava/util/Collection;)Z")) | ||
| private boolean preventAddAll(ArrayListDeque<String> instance, Collection<String> collection) { | ||
| return false; | ||
| } |
Collaborator
There was a problem hiding this comment.
Are you sure this mixin does not affect any other behavior?
| } | ||
|
|
||
| private static int clearChat(FabricClientCommandSource source, boolean clearHistory) { | ||
| source.getClient().inGameHud.getChatHud().clear(clearHistory); |
Collaborator
There was a problem hiding this comment.
You mentioned that F3+3 and /cclearchat false both clear chat while leaving command history accessible while /cclearchat true clears chat and removes all command history for the current session. The former behavior is expected because chat isn't persisted across sessions, but should /cclearchat true also clear command history across sessions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
clearHistoryargument only clears the history in memory, the history will be restored once the game is restarted.