Skip to content

Fix blocky effect#29

Open
SarahAlidoost wants to merge 17 commits intomainfrom
fix_blocky_effect
Open

Fix blocky effect#29
SarahAlidoost wants to merge 17 commits intomainfrom
fix_blocky_effect

Conversation

@SarahAlidoost
Copy link
Member

@SarahAlidoost SarahAlidoost commented Mar 2, 2026

closes #17

This PR adds :

This PR fixes main things as:

  • a bug in the optimization loop in the notebook, how loss is calculated
  • a bug in the optimization loop in the notebook, how land mask is applying
  • a bug in reshaping arrays inside the model
  • a bug in the notebook in inference (prediction cell).

This PR also improves:

  • the spatial refinemnet
  • the dataset class to cover the whole input data
  • disable overlapping data batches created by dataset because it affects the loss

Results:
Note: As can be seen in the final plots, there is not spatial artifacts. I also run the notebook on residuals in this branch. The results also are without artifacts.

Note: The notebooks in this PR can be run on local systems. If the input size or data patch size are changed, the model patch size and overlap should be adjusted accordingly.

@SarahAlidoost SarahAlidoost marked this pull request as ready for review March 6, 2026 09:18
@SarahAlidoost
Copy link
Member Author

@meiertgrootes please also see the top comment when reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Understand origin of repetitive spatial patterns in predicted data.

1 participant