Skip to content

Fix primary key validation in transactional methods#987

Merged
andrykonchin merged 3 commits intomasterfrom
ak/fix-primary-key-validation-in-transactional-methods
Mar 5, 2026
Merged

Fix primary key validation in transactional methods#987
andrykonchin merged 3 commits intomasterfrom
ak/fix-primary-key-validation-in-transactional-methods

Conversation

@andrykonchin
Copy link
Member

Fix transactional #save and #destroy to validate primary key (and raise MissingHashKey, MissingRangeKey if keys are blank) after running before/around callbacks.

Close #986

@andrykonchin andrykonchin force-pushed the ak/fix-primary-key-validation-in-transactional-methods branch from a226f14 to d97772f Compare March 5, 2026 17:50
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Code Coverage

Package Line Rate Health
dynamoid 92%
Summary 92% (3823 / 4135)

Minimum allowed line rate is 90%

@andrykonchin andrykonchin merged commit 9c970fd into master Mar 5, 2026
69 checks passed
@andrykonchin andrykonchin deleted the ak/fix-primary-key-validation-in-transactional-methods branch March 5, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Callbacks and validations happen in different order in transaction

1 participant