Skip to content

RS-19020: Add test for 422 error (bad path) response from datamart #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cadigal-displayr merged 4 commits into from
Feb 4, 2026
Merged

RS-19020: Add test for 422 error (bad path) response from datamart #78

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c1005f
Code style - indentation should be 4 spaces
Cadigal-displayr Feb 4, 2026
4cabf68
Add 422 test
Cadigal-displayr Feb 4, 2026
d511531
Test failure
Cadigal-displayr Feb 4, 2026
06d1e10
Revert "Test failure"
Cadigal-displayr Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
222 changes: 120 additions & 102 deletions tests/testthat/test-datamart.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,57 +1,58 @@
library (testthat)

test_that("SaveData/LoadData", {
skip_if(!nzchar(companySecret), "Not in test environment or no company set up")

# RDS
expect_invisible(QSaveData(mtcars, "mtcars.rds"))
expect_true(QFileExists("mtcars.rds"))
rds <- QLoadData("mtcars.rds")
expect_equivalent(mtcars, rds)

# CSV
expect_invisible(QSaveData(mtcars, "mtcars.csv"))
expect_true(QFileExists("mtcars.csv"))
expect_error(QLoadData("mtcars.csv"), NA)

# SAV
expect_invisible(QSaveData(mtcars, "mtcars.sav"))
expect_true(QFileExists("mtcars.sav"))
expect_error(QLoadData("mtcars.sav"), NA)

# XLSX
expect_invisible(QSaveData(mtcars, "mtcars.xlsx"))
expect_true(QFileExists("mtcars.xlsx"))
expect_equal(dim(QLoadData("mtcars.xlsx")), dim(mtcars))

# GIF
library(gganimate)
p <- ggplot(iris, aes(x = Petal.Width, y = Petal.Length)) + geom_point()
anim <- p + transition_states(Species, transition_length = 2, state_length = 1)
anim <- animate(anim, renderer = gifski_renderer())

expect_invisible(QSaveData(anim, "anim.gif"))
expect_true(QFileExists("anim.gif"))
expect_error(QLoadData("anim.gif"), "Invalid file type specified.")

# Compressed SAV
expect_warning(QSaveData(mtcars, "mtcars.sav",
skip_if(!nzchar(companySecret), "Not in test environment or no company set up")

# RDS
expect_invisible(QSaveData(mtcars, "mtcars.rds"))
expect_true(QFileExists("mtcars.rds"))
rds <- QLoadData("mtcars.rds")
expect_equivalent(mtcars, rds)

# CSV
expect_invisible(QSaveData(mtcars, "mtcars.csv"))
expect_true(QFileExists("mtcars.csv"))
expect_error(QLoadData("mtcars.csv"), NA)

# SAV
expect_invisible(QSaveData(mtcars, "mtcars.sav"))
expect_true(QFileExists("mtcars.sav"))
expect_error(QLoadData("mtcars.sav"), NA)

# XLSX
expect_invisible(QSaveData(mtcars, "mtcars.xlsx"))
expect_true(QFileExists("mtcars.xlsx"))
expect_equal(dim(QLoadData("mtcars.xlsx")), dim(mtcars))

# GIF
library(gganimate)
p <- ggplot(iris, aes(x = Petal.Width, y = Petal.Length)) + geom_point()
anim <- p + transition_states(Species, transition_length = 2, state_length = 1)
anim <- animate(anim, renderer = gifski_renderer())

expect_invisible(QSaveData(anim, "anim.gif"))
expect_true(QFileExists("anim.gif"))
expect_error(QLoadData("anim.gif"), "Invalid file type specified.")

# Compressed SAV
expect_warning(QSaveData(mtcars, "mtcars.sav",
compression.file.size.threshold = 1),
"Object compressed into a zip file and uploaded to Displayr Cloud Drive.")
expect_true(QFileExists("mtcars.zip"))
expect_true(QFileExists("mtcars.zip"))
})

test_that("Save/Load Data: bad cases", {
skip_if(!nzchar(companySecret), "Not in test environment or no company set up")
skip_if(!nzchar(companySecret), "Not in test environment or no company set up")

# Not-existent file
bad_name <- "anamethatdoesnotexistfortesting"
QFileExists(bad_name) |> expect_false() |> expect_warning("may not exist in the Displayr Cloud Drive or you may not have permission")
QLoadData(bad_name) |> expect_error("may not exist in the Displayr Cloud Drive or you may not have permission")
# Not-existent file
bad_name <- "anamethatdoesnotexistfortesting"
QFileExists(bad_name) |> expect_false() |> expect_warning("may not exist in the Displayr Cloud Drive or you may not have permission")
QLoadData(bad_name) |> expect_error("may not exist in the Displayr Cloud Drive or you may not have permission")

# Invalid filetypes
# - note that we don't have tests for Content-Types
QSaveData(mtcars, "mtcars.notrdsorcsv") |> expect_error("Invalid file type specified")

# Invalid filetypes
# - note that we don't have tests for Content-Types
QSaveData(mtcars, "mtcars.notrdsorcsv") |> expect_error("Invalid file type specified")
# 404 Error
mockedPOST <- function() {
list(status_code = 404)
Expand All @@ -68,76 +69,93 @@ test_that("Save/Load Data: bad cases", {
),
fixed = TRUE
)

# 422 Error (Bad path)
mockedPOST <- function() {
list(status_code = 422)
}
formals(mockedPOST) <- formals(httr::POST)
with_mocked_bindings(
POST = mockedPOST,
QSaveData(mtcars, r"(FolderThatDoesNotExist\\file.rds)")
) |>
expect_error(
paste0("QSaveData has encountered an unknown error. ",
"422: The file could not properly be saved. ",
"The likely cause was an incorrect path preceding the filename, or insufficient access to the file path."
),
fixed = TRUE
)
})

test_that("File Connection: raw", {
skip_if(!nzchar(companySecret), "Not in test environment or no company set up")
skip_if(!nzchar(companySecret), "Not in test environment or no company set up")

# Test various file formats
# raw file
filename <- "raw_test"
expect_silent(conn <- QFileOpen(filename, "w"))
txt_string <- "This is a test line."
# Test various file formats
# raw file
filename <- "raw_test"
expect_silent(conn <- QFileOpen(filename, "w"))
txt_string <- "This is a test line."

writeLines(txt_string, conn)
expect_message(expect_invisible(close(conn)))
writeLines(txt_string, conn)
expect_message(expect_invisible(close(conn)))

expect_silent(conn <- QFileOpen(filename))
expect_silent(read_lines <- readLines(conn, warn = FALSE))
expect_equal(txt_string, read_lines)
expect_silent(conn <- QFileOpen(filename))
expect_silent(read_lines <- readLines(conn, warn = FALSE))
expect_equal(txt_string, read_lines)

expect_silent(expect_invisible(close(conn)))
expect_silent(expect_invisible(close(conn)))
})

test_that("File Connection: rds", {
skip_if(!nzchar(companySecret), "Not in test environment or no company set up")
skip_if(!nzchar(companySecret), "Not in test environment or no company set up")

# csv file
filename <- "test.rds"
# csv file
filename <- "test.rds"

expect_silent(conn <- QFileOpen(filename, "w"))
expect_silent(conn <- QFileOpen(filename, "w"))

expect_silent(saveRDS(mtcars, conn, ascii = TRUE))
expect_message(expect_invisible(close(conn)))
expect_silent(saveRDS(mtcars, conn, ascii = TRUE))
expect_message(expect_invisible(close(conn)))

expect_silent(conn <- QFileOpen(filename))
expect_silent(csv <- readRDS(gzcon(conn)))
expect_silent(conn <- QFileOpen(filename))
expect_silent(csv <- readRDS(gzcon(conn)))

expect_silent(expect_invisible(close(conn)))
expect_silent(expect_invisible(close(conn)))
})

test_that("File Connection: csv", {
skip_if(!nzchar(companySecret), "Not in test environment or no company set up")
skip_if(!nzchar(companySecret), "Not in test environment or no company set up")

# csv file
filename <- "test.csv"
# csv file
filename <- "test.csv"

expect_silent(conn <- QFileOpen(filename, "w"))
expect_silent(conn <- QFileOpen(filename, "w"))

expect_silent(write.csv(mtcars, conn))
expect_message(expect_invisible(close(conn)))
expect_silent(write.csv(mtcars, conn))
expect_message(expect_invisible(close(conn)))

expect_silent(conn <- QFileOpen(filename))
expect_silent(csv <- read.csv(conn))
expect_silent(conn <- QFileOpen(filename))
expect_silent(csv <- read.csv(conn))

expect_silent(expect_invisible(close(conn)))
expect_silent(expect_invisible(close(conn)))
})

test_that("File Connection: json", {
skip_if(!nzchar(companySecret), "Not in test environment or no company set up")
# json file
filename <- "test.json"
skip_if(!nzchar(companySecret), "Not in test environment or no company set up")
# json file
filename <- "test.json"

expect_silent(conn <- QFileOpen(filename, "w"))
expect_silent(conn <- QFileOpen(filename, "w"))

expect_silent(writeLines(jsonlite::toJSON(mtcars), conn))
expect_message(expect_invisible(close(conn)))
expect_silent(writeLines(jsonlite::toJSON(mtcars), conn))
expect_message(expect_invisible(close(conn)))

expect_silent(conn <- QFileOpen(filename))
expect_silent(json <- jsonlite::fromJSON(readLines(conn, warn = FALSE)))
expect_equivalent(json, mtcars)
expect_silent(conn <- QFileOpen(filename))
expect_silent(json <- jsonlite::fromJSON(readLines(conn, warn = FALSE)))
expect_equivalent(json, mtcars)

expect_silent(expect_invisible(close(conn)))
expect_silent(expect_invisible(close(conn)))
})

test_that("DS-3269: Data Mart unavailable",
Expand Down Expand Up @@ -183,27 +201,27 @@ test_that("QGetSharedUrl: bad cases", {

test_that("Delete Data",
{
skip_if(!nzchar(companySecret), "Not in test environment or no company set up")
skip_if(!nzchar(companySecret), "Not in test environment or no company set up")

local_mocked_bindings(getApiRoot = function(endpoint = "DataMart") paste0("https://master.displayr.com/api/", endpoint, "/"))
prevClientId <- clientId
assign("clientId", "-948985", envir = .GlobalEnv)
on.exit(assign("clientId", prevClientId, envir = .GlobalEnv))
local_mocked_bindings(getApiRoot = function(endpoint = "DataMart") paste0("https://master.displayr.com/api/", endpoint, "/"))
prevClientId <- clientId
assign("clientId", "-948985", envir = .GlobalEnv)
on.exit(assign("clientId", prevClientId, envir = .GlobalEnv))

expect_invisible(QSaveData(mtcars, "mtcars.rds"))
expect_true(QFileExists("mtcars.rds"))
expect_invisible(QDeleteFiles(c("mtcars.rds")))
expect_warning(QFileExists("mtcars.rds"), "may not exist in the Displayr Cloud Drive or you may not have permission")
expect_invisible(QSaveData(mtcars, "mtcars.rds"))
expect_true(QFileExists("mtcars.rds"))
expect_invisible(QDeleteFiles(c("mtcars.rds")))
expect_warning(QFileExists("mtcars.rds"), "may not exist in the Displayr Cloud Drive or you may not have permission")

expect_invisible(QSaveData(mtcars, "mtcars.csv"))
expect_invisible(QSaveData(mtcars, "mtcars.sav"))
expect_true(QFileExists("mtcars.csv"))
expect_true(QFileExists("mtcars.sav"))
expect_invisible(QSaveData(mtcars, "mtcars.csv"))
expect_invisible(QSaveData(mtcars, "mtcars.sav"))
expect_true(QFileExists("mtcars.csv"))
expect_true(QFileExists("mtcars.sav"))

expect_invisible(QDeleteFiles(c("mtcars.csv", "mtcars.sav")))
expect_warning(QFileExists("mtcars.csv"), "may not exist in the Displayr Cloud Drive or you may not have permission")
expect_warning(QFileExists("mtcars.sav"), "may not exist in the Displayr Cloud Drive or you may not have permission")
expect_invisible(QDeleteFiles(c("mtcars.csv", "mtcars.sav")))
expect_warning(QFileExists("mtcars.csv"), "may not exist in the Displayr Cloud Drive or you may not have permission")
expect_warning(QFileExists("mtcars.sav"), "may not exist in the Displayr Cloud Drive or you may not have permission")

# Should still succeed even if files don't exist
expect_invisible(QDeleteFiles(c("mtcars.csv", "mtcars.sav")))
# Should still succeed even if files don't exist
expect_invisible(QDeleteFiles(c("mtcars.csv", "mtcars.sav")))
})
Loading