Conversation
|
I would suggest waiting with this until after RabbitMQ is deployed and support for ActiveMQ is deprecated/removed. |
Anthchirp
left a comment
There was a problem hiding this comment.
Having said that, I'm not hostile to adding this if you're fine with it being completely rewritten later.
I would suggest though to rename the command to zocalo.run_system_tests to match dlstbx and give a stronger sense of what this is about.
|
Note: The original agreement was that this wouldn't go into the zocalo package, but into zocalo-dls. |
|
I think its useful outside of dls? I already have this running like you on a 30 min basis to test various services. I keep the esrf specific system tests in an esrf repo (i.e. we have our own file watcher), but i think the general code is useful to all sites? |
|
md converted to rst, cli tool renamed |
|
This pull request introduces 1 alert when merging c928650 into 702d3fc - view on LGTM.com new alerts:
|
Tests are now found via entry points. Also added a pytest style -k to filter tests.
Probably need a config option to disable certain tests, for example once switched to rabbitmq we won't want to run the activemq test.