Address path tracer merge leftover comments#991
Address path tracer merge leftover comments#991devshgraphicsprogramming merged 87 commits intomasterfrom
Conversation
…mek's remove_core_matrix branch, added create from mat3x3
…c cast to/from truncated quat
|
|
include/nbl/builtin/hlsl/sampling/projected_spherical_triangle.hlsl
Outdated
Show resolved
Hide resolved
include/nbl/builtin/hlsl/sampling/projected_spherical_triangle.hlsl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
most parameters should be members #966 (comment)
There was a problem hiding this comment.
Also #966 (comment)
There was a problem hiding this comment.
for next sampling PR, to rework in line with concepts of #1001
| return retval; | ||
| } | ||
|
|
||
| vector4_type computeBilinearPatch(const vector3_type receiverNormal, bool isBSDF) |
There was a problem hiding this comment.
why is this returning vector4_type instead of sampling::bilinear
There was a problem hiding this comment.
ok sampling PR
| static ProjectedSphericalTriangle<T> create(NBL_CONST_REF_ARG(shapes::SphericalTriangle<T>) tri) | ||
| { | ||
| ProjectedSphericalTriangle<T> retval; | ||
| retval.tri = tri; | ||
| return retval; | ||
| } |
There was a problem hiding this comment.
remove, see #966 (comment)
There was a problem hiding this comment.
ok sampling PR
| vector3_type cos_vertices, sin_vertices; | ||
| const scalar_type solidAngle = tri.solidAngleOfTriangle(cos_vertices, sin_vertices, cos_a, cos_c, csc_b, csc_c); | ||
| const scalar_type solidAngle = tri.solidAngle(cos_vertices, sin_vertices); |
There was a problem hiding this comment.
should be precomputed and stored as members #966 (comment)
There was a problem hiding this comment.
ok sampling PR
There was a problem hiding this comment.
again function with bazillion parameters that are really local members
There was a problem hiding this comment.
ok sampling PR
| materialSystem, scene, intersectP, interaction, | ||
| isBSDF, eps0, depth | ||
| scene, materialSystem, intersectP, interaction, | ||
| eps0, depth |
There was a problem hiding this comment.
you don't need depth
There was a problem hiding this comment.
depth is used to adjust newRayMaxT inside the nee though?
There was a problem hiding this comment.
its you need it in userspace, pass it around clandestinely (ray payload)
…e internally to use iso
…rsected ray and gives intersection
… eval and pdf don't need to take in cache
| ((NBL_CONCEPT_REQ_EXPR_RET_TYPE)((ray.template setInteraction<bxdf::surface_interactions::SIsotropic<bxdf::ray_dir_info::SBasic<float>, typename T::spectral_type> >(interaction)), ::nbl::hlsl::is_same_v, void)) | ||
| ((NBL_CONCEPT_REQ_EXPR_RET_TYPE)((ray.initPayload()), ::nbl::hlsl::is_same_v, void)) | ||
| ((NBL_CONCEPT_REQ_EXPR_RET_TYPE)((ray.shouldDoMIS()), ::nbl::hlsl::is_same_v, bool)) | ||
| ((NBL_CONCEPT_REQ_EXPR_RET_TYPE)((ray.foundEmissiveMIS(scalar)), ::nbl::hlsl::is_same_v, typename T::spectral_type)) |
There was a problem hiding this comment.
not spectral_type, scalar_type
4 participants
Makes changes left from #966