[FIX] DidNotStartInTimeException & DidNotStopInTimeException#377
Open
meliksahcakirr wants to merge 1 commit intoDev-hwang:masterfrom
Open
[FIX] DidNotStartInTimeException & DidNotStopInTimeException#377meliksahcakirr wants to merge 1 commit intoDev-hwang:masterfrom
meliksahcakirr wants to merge 1 commit intoDev-hwang:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Both
update()andstop()operations callisRunningService()at the beginning of the function.If the service is already running, we know that it has already been started.
However, at the end of these functions
ContextCompat.startForegroundService(context, nIntent)is still called. This re-triggers the foreground service start contract, even though the service is already running.Proposed Change
Instead of calling
startForegroundService, the code should callstartServicewhen the service is already running.This avoids re-triggering the internal
startForeground()requirement that applies whenstartForegroundServiceis used.Motivation
In our applications we frequently observe the following exceptions:
ForegroundServiceDidNotStartInTimeForegroundServiceDidNotStopInTimeAfter applying this change on our side (using
startServicewhen the service is already running), these exceptions disappeared completely.Additional Context
We initially expected that overriding the
timeOut()function would eliminate theForegroundServiceDidNotStopInTimeerror. However, we continued to observe it until applying the change proposed in this PR.