IAsyncEnumerable on DelayedQuery#364
Open
snaumenko-st wants to merge 3 commits intoDataObjects-NET:masterfrom
Open
IAsyncEnumerable on DelayedQuery#364snaumenko-st wants to merge 3 commits intoDataObjects-NET:masterfrom
snaumenko-st wants to merge 3 commits intoDataObjects-NET:masterfrom
Conversation
…uery while asynchronously prefetching data
Contributor
|
Hello @snaumenko-st, Oh my gosh, I can feel your frustration when you had an API to change session handler but no way to get current session handler to instantiate yours. Sorry for that. We'll fix it and provide proper way of changing handlers once we have this API. I also appreciate the test you have created. I have some comments on it.
|
Author
|
@alex-kulakov Thanks for your comments. I tried fixing the tests as you suggested and they look a little cleaner now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce IAsyncEnumerable on DelayedQuery to utilize async Session query while asynchronously prefetching data.
We need IAsyncEnumerable implementation here as if it is used inside a Prefetch, which is a fairly common case, it is used as the IEnumerable source and will fall back to a synchronous implementation even in a chain of asynchronous calls. The new unit test shows that behavior.