DelayedQueryWithDtoCtorParamTest test#259
Open
SergeiPavlov wants to merge 2 commits intoDataObjects-NET:masterfrom
Open
DelayedQueryWithDtoCtorParamTest test#259SergeiPavlov wants to merge 2 commits intoDataObjects-NET:masterfrom
SergeiPavlov wants to merge 2 commits intoDataObjects-NET:masterfrom
Conversation
Contributor
|
I would throw an exception in such cases instead of not caching query. The query is not cacheable by default. We can mislead user and not cache query and user will go back to us and ask why we don't cache his query, or we can tell the truth that we cannot cache such query and offer user to declare a local variable that will be processed just fine. The third option is providing a way to pass such objects to the query and somehow put such objects to ParameterContext and resolve all the constants that outside of closure to some variable in ParameterContext instance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.