Skip to content

Update usage of FragmentErrorBits to FragmentStatusBits #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eflumerf wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Update usage of FragmentErrorBits to FragmentStatusBits #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b74b2f
Update usage of FragmentErrorBits to FragmentStatusBits
eflumerf Jan 22, 2026
c6bae7d
Rename TriggerRecordErrorBits to TriggerRecordStatusBits
eflumerf Jan 22, 2026
82f1865
Merge remote-tracking branch 'origin/develop' into eflumerf/FragmentS…
eflumerf Feb 4, 2026
4ad8399
Merge branch 'develop' into eflumerf/FragmentStatusBits
eflumerf Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/FakeDataProdModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ FakeDataProdModule::process_data_request(dfmessages::DataRequest& data_request)
data_fragment_ptr->set_trigger_number(data_request.trigger_number);
data_fragment_ptr->set_run_number(m_run_number);
data_fragment_ptr->set_element_id(m_sourceid);
data_fragment_ptr->set_error_bits(0);
data_fragment_ptr->set_status_bits(0); // Do we want to have a kFakeData status bit?
Copy link
Contributor

@wesketchum wesketchum Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can me either just answer this question, or make an issue to ask/discuss/answer this question rather than just leave it as a comment? I worry if we leave it here, it will stay here for a decade ...

data_fragment_ptr->set_type(m_fragment_type);
data_fragment_ptr->set_trigger_timestamp(data_request.trigger_timestamp);
data_fragment_ptr->set_window_begin(data_request.request_information.window_begin);
Expand Down
9 changes: 5 additions & 4 deletions plugins/FragmentAggregatorModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,12 +216,13 @@ FragmentAggregatorModule::process_fragment(std::unique_ptr<daqdataformats::Fragm
m_timestamp_before_frag = get_current_time_us();
m_fragments_received++;

std::bitset<32> error_bits = fragment->get_error_bits();
if (error_bits[static_cast<size_t>(dunedaq::daqdataformats::FragmentErrorBits::kDataNotFound)])
std::bitset<32> status_bits = fragment->get_status_bits();
if (status_bits[static_cast<size_t>(dunedaq::daqdataformats::FragmentStatusBits::kEmptyFragment)] ||
status_bits[static_cast<size_t>(dunedaq::daqdataformats::FragmentStatusBits::kLatencyBufferEmpty)])
m_fragments_empty++;
if (error_bits[static_cast<size_t>(dunedaq::daqdataformats::FragmentErrorBits::kIncomplete)])
if (status_bits[static_cast<size_t>(dunedaq::daqdataformats::FragmentStatusBits::kIncomplete)])
m_fragments_incomplete++;
if (error_bits[static_cast<size_t>(dunedaq::daqdataformats::FragmentErrorBits::kInvalidWindow)])
if (status_bits[static_cast<size_t>(dunedaq::daqdataformats::FragmentStatusBits::kInvalidRequestWindow)])
m_fragments_invalid++;

auto dr_iter = m_data_req_map.find(
Expand Down
4 changes: 2 additions & 2 deletions plugins/TRBModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ enum
namespace dunedaq {
namespace dfmodules {

using daqdataformats::TriggerRecordErrorBits;
using daqdataformats::TriggerRecordStatusBits;

TRBModule::TRBModule(const std::string& name)
: dunedaq::appfwk::DAQModule(name)
Expand Down Expand Up @@ -475,7 +475,7 @@ TRBModule::extract_trigger_record(const TriggerId& id)

m_lost_fragments += missing_fragments;
m_pending_fragment_counter -= missing_fragments;
temp->get_header_ref().set_error_bit(TriggerRecordErrorBits::kIncomplete, true);
temp->get_header_ref().set_status_bit(TriggerRecordStatusBits::kIncomplete, true);

ers::error(IncompleteTriggerRecord(ERS_HERE, (m_stop_requested.load() ? "at Stop time " : ""), id,
temp->get_fragments_ref().size(),
Expand Down