item: add new --total-quality option to filter items according to their total quality#1511
Merged
ab9rf merged 6 commits intoDFHack:masterfrom Nov 17, 2025
Merged
item: add new --total-quality option to filter items according to their total quality#1511ab9rf merged 6 commits intoDFHack:masterfrom
item: add new --total-quality option to filter items according to their total quality#1511ab9rf merged 6 commits intoDFHack:masterfrom
Conversation
Member
|
I am not inclined to accept this outright, since there may be extant use cases that depend on using the base quality. I would support an option giving the user the ability to switch between using base quality or overall quality. |
Contributor
Author
|
Hmm, I think the best way forward is to make it a new function so that it could also be called programatically like the other functions. I'm still trying to figure out the best way to let the user switch between the two. |
amade-w
changed the title
item to use getOverallQuality when evaluating item qualityitem: add new --total-quality option to filter items according to their total quality
ab9rf
approved these changes
Oct 30, 2025
Member
ab9rf
left a comment
ab9rf
left a comment
There was a problem hiding this comment.
note that this will be held until after the next release since we're in prerelease freeze now and this counts as a "feature"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: DFHack/dfhack#5603