Support for modded honey in ban-cooking

[Droseran]

This patch allows ban-cooking to ban honey/brewable materials added by creatures other than honey bees. This includes vanilla bumblebees, though their honey is not currently obtainable in vanilla. However, there are mods that make bumblebees hiveable, as well as adding other types of hiveable bees.

[SilasD]

This works; there's nothing wrong with it.

But I would argue that the entire funcs.honey shouldn't really exist. Instead, this code should be folded into funcs.brew.

funcs.brew searches for materials that have a reaction product that is alcohol. And that's what this code does. The only difference here is iterating over creatures instead of plants.

Separating the code just means that anybody who is trying to ban-cooking of brewables needs to ban two categories instead one.

(Combining the two would also make it easier to refactor out the copy-paste code.)

[ab9rf]

This works; there's nothing wrong with it.

But I would argue that the entire funcs.honey shouldn't really exist. Instead, this code should be folded into funcs.brew.

funcs.brew searches for materials that have a reaction product that is alcohol. And that's what this code does. The only difference here is iterating over creatures instead of plants.

Separating the code just means that anybody who is trying to ban-cooking of brewables needs to ban two categories instead one.

(Combining the two would also make it easier to refactor out the copy-paste code.)

While there's merit to this suggestion, I'm not going to block this change for this alone. Feel free to submit a followup PR.