Skip to content

fix: cap undo history, fix btoa unicode crash, add quota fallback (#352)#353

Open
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
avinxshKD:fix/undo-history-btoa-quota
Open

fix: cap undo history, fix btoa unicode crash, add quota fallback (#352)#353
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
avinxshKD:fix/undo-history-btoa-quota

Conversation

@avinxshKD
Copy link

Fixes #352

  1. actionArr was never pruned, capped at 100 entries, trims from the front
  2. btoa() crashes on unicode node names , switched stringifyAction to plain JSON.stringify, parseAction falls back to atob for old saved data
  3. localStorage quota exceeded silently killed the graph, save() now retries without actionHistory if the first write fails

@avinxshKD
Copy link
Author

@pradeeban pls have a look

@pradeeban
Copy link
Member

@avinxshKD merge conflicts. Pls check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants