Fix and collect the Entity & Player arguments page#14
Open
willkroboth wants to merge 1 commit intomasterfrom
Open
Fix and collect the Entity & Player arguments page#14willkroboth wants to merge 1 commit intomasterfrom
willkroboth wants to merge 1 commit intomasterfrom
Conversation
Move the example into the entity selector section rather than the player profile section, matching the argument used in the examples. Move non Paper/Spigot specific examples into the Bukkit reference code section to reduce duplicated information (only `PlayerProfileArgument` and `AsyncPlayerProfileArgument` are Paper/Spigot specific)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThatCorona pointed out a runtime issue with the player name suggestions example on Discord.
It currently uses a
PlayerProfileArgument, but tries to cast the result toPlayerrather thanPlayerProfile. APlayermakes sense for the examplewarpcommand, so I changed it to use anEntitySelectorArgument.OnePlayer. Therefore, I moved the example from thePlayerProfile argumentsection to theEntity selector argumentsection.I also moved the entity examples that are not Paper/Spigot specific into the Bukkit reference code module (only the example that uses the
AsyncPlayerProfileArgumentneeds Paper/Spigot). Since they work the same and use the same code, I think having them in one place makes them easier to update.