Skip to content

Comments

feat: logical properties for inset and overflow#3269

Open
LinKCoding wants to merge 7 commits intokl-gmt-1451-logical-props--jh-revertfrom
kl-gmt-1509-gamut-inset-overflow
Open

feat: logical properties for inset and overflow#3269
LinKCoding wants to merge 7 commits intokl-gmt-1451-logical-props--jh-revertfrom
kl-gmt-1509-gamut-inset-overflow

Conversation

@LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Feb 13, 2026

Overview

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1509
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to Props/Positioning story
  2. Look over the example and the token table
  3. Test the changes using the Logical/Physical props button
  4. Test the changes using the RTL/LTR props button
  5. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@nx-cloud
Copy link

nx-cloud bot commented Feb 13, 2026

View your CI Pipeline Execution ↗ for commit 44618b0


☁️ Nx Cloud last updated this comment at 2026-02-20 16:46:45 UTC

@codecov
Copy link

codecov bot commented Feb 13, 2026

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@LinKCoding LinKCoding changed the base branch from main to kl-gmt-1451-logical-props February 13, 2026 21:31
@LinKCoding LinKCoding changed the base branch from kl-gmt-1451-logical-props to kl-gmt-1451-logical-props--jh-revert February 13, 2026 21:51
@codecademydev
Copy link
Collaborator

📬 Published Alpha Packages:

@codecademy/gamut@68.1.0-alpha.4dfb89.0
@codecademy/gamut-icons@9.55.2-alpha.4dfb89.0
@codecademy/gamut-illustrations@0.58.4-alpha.4dfb89.0
@codecademy/gamut-kit@0.6.582-alpha.4dfb89.0
@codecademy/gamut-patterns@0.10.23-alpha.4dfb89.0
@codecademy/gamut-styles@17.12.0-alpha.4dfb89.0
@codecademy/gamut-tests@5.3.0-alpha.4dfb89.0
@codecademy/styleguide@79.2.0-alpha.4dfb89.0
@codecademy/variance@0.26.0-alpha.4dfb89.0

@github-actions
Copy link
Contributor

@LinKCoding LinKCoding marked this pull request as ready for review February 20, 2026 17:02
@LinKCoding LinKCoding requested a review from a team as a code owner February 20, 2026 17:02
@LinKCoding LinKCoding requested review from aresnik11, dreamwasp, jakemhiller and sh0ji and removed request for a team February 20, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants