Sheffield | 26-ITP-January | Connor Parsons | Sprint 2 | Form-Controls

[connorpar]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

• Created a functional form for someone to order T-shirts

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	162702d
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6990565d0b73c000085ad70e
😎 Deploy Preview	https://deploy-preview-1175--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[cjyuan]

• Some of the input elements are missing an important attribute. Without this attribute, the input values will not be sent to the server.

• The requirement, "all fields are required", has not yet been met.

Can you address these issues?

[cjyuan]

• The requirement, "all fields are required", still has not been satisfied.

---

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

• Reply to their feedback.
  • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
    • You may find the suggestions in this PR Guide useful.
  • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
• Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
  • Without this label, the reviewer would not know if your changes is ready to be reviewed.

[connorpar]

I am pretty sure that all the fields are now required. I thought I had checked that every field was required before but I didn't check to see if the form would submit without writing anything in the "name" section.
I previously tested the name section by putting spaces and only a single character but forgot to check leaving it empty.

[cjyuan]

All good now. Well done!

[connorpar]

Thank you!