Skip to content

London | 26-ITP-January | Carlos Abreu | Sprint 2 | Form Controls#1155

Open
carlosyabreu wants to merge 6 commits intoCodeYourFuture:mainfrom
carlosyabreu:feature/form-controls
Open

London | 26-ITP-January | Carlos Abreu | Sprint 2 | Form Controls#1155
carlosyabreu wants to merge 6 commits intoCodeYourFuture:mainfrom
carlosyabreu:feature/form-controls

Conversation

@carlosyabreu
Copy link

@carlosyabreu carlosyabreu commented Feb 6, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Form controls project to be merge into upstream main branch

@netlify
Copy link

netlify bot commented Feb 6, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit c2bfd3d
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6988ec57059e290008d7bcfd
😎 Deploy Preview https://deploy-preview-1155--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 84 (🔴 down 2 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 6, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 6, 2026
@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 6, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 6, 2026
@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 6, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 6, 2026
@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@carlosyabreu carlosyabreu changed the title London | 26-ITP-January | Carlos Abreu | Sprint 1 | Form Controls London | 26-ITP-January | Carlos Abreu | Sprint 2 | Form Controls Feb 7, 2026
@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@A-O-Emmanuel A-O-Emmanuel added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 7, 2026
A-O-Emmanuel
A-O-Emmanuel reviewed Feb 7, 2026
View reviewed changes
Copy link

@A-O-Emmanuel A-O-Emmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments for you.

Form-Controls/index.html Outdated
name="customer-name"
required
minlength="2"
placeholder="Enter first and last name">
Copy link

@A-O-Emmanuel A-O-Emmanuel Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of another way to verify if the customer name is a valid name

Copy link
Author

@carlosyabreu carlosyabreu Feb 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly!
Here is one alternative approaches to validating a customer name in HTML form controls:

Using pattern attribute with regex
This allows for more specific validation patterns:

Name

Must be at least 2 characters long

Copy link

@A-O-Emmanuel A-O-Emmanuel Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, do that.

Copy link
Author

@carlosyabreu carlosyabreu Feb 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evening Mr. Emmanuel

I just added to the codebase the regular expression pattern validation of the customer name in form controls.
Cheers!

Form-Controls/index.html Outdated
id="customer-email"
name="customer-email"
required
placeholder="example@domain.com">
Copy link

@A-O-Emmanuel A-O-Emmanuel Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also think of another way to verify if the customer email is a valid email?

Copy link
Author

@carlosyabreu carlosyabreu Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using multiple attributes for comprehensive validation

Email Address

We'll use this to verify your email format (6-254 characters)

Copy link
Author

@carlosyabreu carlosyabreu Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again I also added to the regular expression pattern validation for the email on form controls.
Thanks for the remarks.

Cheers!

@A-O-Emmanuel A-O-Emmanuel added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 7, 2026
@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@A-O-Emmanuel A-O-Emmanuel added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 8, 2026
@carlosyabreu carlosyabreu mentioned this pull request Feb 10, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@A-O-Emmanuel A-O-Emmanuel A-O-Emmanuel left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlosyabreu @A-O-Emmanuel