generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 419
London | 26-ITP-Jan | Miriam Jorna | Sprint 2 | Form Controls #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
miriamjorna
wants to merge
13
commits into
CodeYourFuture:main
Choose a base branch
from
miriamjorna:tshirt-form-clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8063ee8
wrote out reqs as comments
hoimir 6374d90
putting basic elements of the form in place
hoimir 6b2b9ef
basic form set up
hoimir 213f159
Form scaffolding up
hoimir af84015
ticked off the boxes in the Readme file
hoimir f127fa5
added submit/reset buttons
hoimir 0dda10a
in the correct branch
hoimir 80e4de5
adapted meta description
hoimir eb221fe
Added "required" to sections
hoimir d6b3b93
Merge branch 'main' into tshirt-form-clean
miriamjorna 257e760
Enforced stricter validation on name, so that text needs to be used (…
hoimir b5508d5
Merge branch 'tshirt-form-clean' of https://github.com/miriamjorna/Mo…
hoimir cebf3c9
- Refactored the labelling on the T-shirt sizes as well (after only d…
hoimir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,135 @@ | ||
| <!DOCTYPE html> | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <title>My T-shirt form exercise</title> | ||
| <meta name="description" content="form exercise: order one T-shirt" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| <h1>T-shirt Picker</h1> | ||
| </header> | ||
| <main> | ||
| <form> | ||
| <form action="/my-handling-form-page" method="post"> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
|
|
||
| <!-- | ||
| NB HTML only - no CSS no JS | ||
|
|
||
| 1/ log customer name | ||
| 2/ validate customer name: a text string of two characters or more | ||
| 3/ log customer email | ||
| 4/ validate customer email (format) | ||
| 5/ offer 3 T-shirt colour choices | ||
| 6/ input must pick one | ||
| 7/ offer 6 sizes: XS, S, M, L, XL, XXL | ||
| 8/ input must pick one | ||
| --> | ||
|
|
||
| <!-- | ||
| 1/ log customer name | ||
| 2/ validate customer name: a text string of two characters or more | ||
| --> | ||
| <p> | ||
| <label for="name"> | ||
| Name: | ||
| <input | ||
| type="text" | ||
| id="name" | ||
| minlength="2" | ||
| name="user_name" | ||
| pattern="[A-Za-z]{2,}" | ||
| title="At least two letters are needed" | ||
| required | ||
| autofocus | ||
| /> | ||
| </label> | ||
| </p> | ||
| <!-- | ||
| 3/ log customer email | ||
| 4/ validate customer email (format) | ||
| --> | ||
| <p> | ||
| <label for="email"> | ||
| Email: | ||
| <input type="email" id="email" name="user_email" required /> | ||
| </label> | ||
| </p> | ||
| <!-- | ||
| 5/ offer 3 T-shirt colour choices | ||
| 6/ input must pick one | ||
| --> | ||
| <fieldset> | ||
| <legend>T-shirt colour</legend> | ||
| <p> | ||
| <label> | ||
| <input type="radio" name="color" value="blue" required /> blue | ||
| </label> | ||
| </p> | ||
| <p> | ||
| <label> | ||
| <input type="radio" name="color" value="black" /> black | ||
| </label> | ||
| </p> | ||
| <p> | ||
| <label> | ||
| <input type="radio" name="color" value="purple" /> purple | ||
| </label> | ||
| </p> | ||
| </fieldset> | ||
| <!-- | ||
| 7/ offer 6 sizes: XS, S, M, L, XL, XXL | ||
| 8/ input must pick one | ||
| --> | ||
| <fieldset> | ||
| <legend>T-shirt size</legend> | ||
| <table> | ||
| <tr> | ||
| <td> | ||
| <label> | ||
| <input type="radio" name="size" value="XS" required />XS | ||
| </label> | ||
| </td> | ||
| <td> </td> | ||
| <td> | ||
| <label> <input type="radio" name="size" value="L" />L </label> | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td> | ||
| <label> <input type="radio" name="size" value="S" />S </label> | ||
| </td> | ||
| <td> </td> | ||
| <td> | ||
| <label> <input type="radio" name="size" value="XL" />XL </label> | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td> | ||
| <label> <input type="radio" name="size" value="M" />M </label> | ||
| </td> | ||
| <td> </td> | ||
| <td> | ||
| <label> | ||
| <input type="radio" name="size" value="XXL" />XXL | ||
| </label> | ||
| </td> | ||
| </tr> | ||
| </table> | ||
| </fieldset> | ||
|
|
||
| <p> </p> | ||
| <input type="submit" value="SUBMIT" /> | ||
| <input type="reset" value="Reset" /> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <p>By HOMEWORK SOLUTION</p> | ||
| <h2>Form by Miriam Jorna</h2> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.